Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add simplified chinese language file #285

Closed
wants to merge 1 commit into from
Closed

✨ Add simplified chinese language file #285

wants to merge 1 commit into from

Conversation

guanguans
Copy link

@guanguans guanguans commented Apr 30, 2024 •
edited
Loading

Changes

  • Affected parts of the app: UI code
  • Estimated impact on performance: low
  • Made a new build with Xcode and tested this: no
  • Tested on macOS version + architecture: Ventura on M1
  • References issue(s): none

Support simplified Chinese localization.

image

@nicoverbruggen
Copy link
Owner

Thank you for translating! I will integrate these into the app for the next update.

nicoverbruggen added a commit that referenced this pull request May 2, 2024
@nicoverbruggen
🌐 Added Chinese translations, credits
ce88f89 
- Chinese translations contributed by @guanguans (via #285).
- Updated the credits so that all translators are now also listed
  separately, since the GitHub issue has been closed.
@nicoverbruggen
Copy link
Owner

Hi @guanguans, thank you for contributing. I've cherry picked your changes and added the translations via ce88f89. Since this is a cherry pick, I'm simply going to close this PR but your translations have been integrated into the app.

I've also updated the credits listing so in About PHP Monitor you are now listed as contributor for the Chinese translation. Much appreciated!

This contribution will be included in the next minor update due for release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guanguans @nicoverbruggen