Current helper binaries are incompatible with fish

[marcoluzi]

Is there an existing issue for this?

• I have searched the existing issues and discussions

Is this feature request related to a problem?

The fish terminal apparently ignores the #!/bin/zsh when i run . pm74 or source pm74. It wants to run the script with the fish syntax and thus returns the following error:

pm74 (line 5): $  is not a valid variable in fish.
[[ $ZSH_EVAL_CONTEXT =~ :file$ ]] \
                              ^
from sourcing file pm74
source: Error while reading file 'pm74'

Describe the solution you'd like to see

Add support for fish shell. Maybe some sort of shell checking when the helper binaries are created.

Additional information or context

No response

[nicoverbruggen]

For this to work, I’d need to detect which shell is in use. This is possible with an additional command.

What is the output of these two commands on your system?

echo $SHELL

dscl . -read ~/ UserShell | sed 's/UserShell: //

That will help me determine which command to use to determine whether Fish is in use. Thanks!

[marcoluzi]

Same output for both:
/opt/homebrew/bin/fish

[nicoverbruggen]

Thanks. I'll see if I can't get this to work later now that I know I can check if fish is in use.

(I did a few experiments already, and I'm not sure I can make it work as seamlessly as it currently does with bash/zsh.)

[nicoverbruggen]

@marcoluzi Good news, I've got this working. I can now detect if the default user shell is Fish, and if so, a Fish-compatible version of the scripts are generated.

Unfortunately, unlike zsh, sourcing scripts requires you to provide the full path to the file you wish to source. The files to be sourced are always generated in ~/.config/phpmon/bin. Fortunately, Fish helps with autocomplete :)

Example usage:

Like the other scripts, the variable is only set for the current terminal session! (This doesn't use fish_add_path, which adds to your $PATH permanently. That isn't the intention, obviously.)

So you can use source ~/.config/phpmon/bin/pm80 for PHP 8.0, and so on.

Please try out this DEV build and let me know if it works as described: phpmon-dev.zip

---

Note: Fish compatible files are only generated if your default shell ($SHELL) contains the substring /fish. To accomplish this on modern macOS, you need to add the binary to /etc/shells and set it with chsh.

According to the output you posted above, this should not be an issue, but for others this may be relevant information:

echo "/opt/homebrew/bin/fish" | sudo tee -a /etc/shells
chsh -s /opt/homebrew/bin/fish

[marcoluzi]

@nicoverbruggen
That's awesome. Thank you so much. <3
Works perfectly fine.

[nicoverbruggen]

Fantastic. This is now included in v6.2, which I've just released! Closing this issue now.