Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Stop Valet Services" not working #225

Closed
pixolin opened this issue Jan 29, 2023 · 4 comments
Closed

"Stop Valet Services" not working #225

pixolin opened this issue Jan 29, 2023 · 4 comments
Assignees
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!

Comments

@pixolin
Copy link

pixolin commented Jan 29, 2023

Describe the bug
If I click in PHP Monitor on First Aid & ServicesStop Valet Services, nothing happens.

Running valet stop in the terminal reports

Stopping php@8.0...
Stopping php...
Stopping nginx...
Valet services have been stopped.

as expected.

To Reproduce

  1. Go to First Aid & Services
  2. Click on Stop Valet Services
  3. Nothing happens. Indicators in PHP Monitor still show all services as active. However, Restart Services works as expected.

Expected behavior
Shut down services as valet stop does.

Required information

  • Did you consult the FAQ in the README? Yes
  • Did you try "Fix My Valet"? Yes
  • OS: MacOS Ventura 13.2 (Apple Silicon)
  • PHP Monitor version 5.7 (1030)

Additional context
App is so cool ❤️. However, sometimes I need to shut down Valet. 🥲

@pixolin pixolin added the bug Something isn't working (correctly). label Jan 29, 2023
@nicoverbruggen
Copy link
Owner

Thanks for reporting! I'll see what's causing this. I probably missed this with all of the rewrites 😅

As a workaround, you can also click on the checkmarks in the services section in the menu. (This toggles the services on/off, albeit one by one.)

@pixolin
Copy link
Author

pixolin commented Jan 29, 2023

I can confirm that the services shut down if I click the icons seperately.
(Hey, bettern than nothing. 😄)

@pixolin
Copy link
Author

pixolin commented Jan 29, 2023

For the sake of completeness:
Unfortunately, running brew doctor also didn't bring any change.

@nicoverbruggen
Copy link
Owner

I found the issue, it was a silly refactor thing that I missed.

I made a new build! Please let me know if this build solved the problem (works on my system now): phpmon.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!
Projects
None yet
Development

No branches or pull requests

2 participants