Fix apache#1778: fix binding to the broker

nicolaferraro · Oct 23, 2020 · a50213b · a50213b
1 parent 5d5bd11
commit a50213b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/util/knative/uri.go b/pkg/util/knative/uri.go
@@ -26,7 +26,7 @@ import (
 	v1 "k8s.io/api/core/v1"
 )
 
-var uriRegexp = regexp.MustCompile(`^knative:[/]*(channel|endpoint|event)(?:$|/([A-Za-z0-9.-]+)(?:[/?].*|$))`)
+var uriRegexp = regexp.MustCompile(`^knative:[/]*(channel|endpoint|event)(?:[?].*|$|/([A-Za-z0-9.-]+)(?:[/?].*|$))`)
 var plainNameRegexp = regexp.MustCompile(`^[A-Za-z0-9.-]+$`)
 
 const (

diff --git a/pkg/util/knative/uri_test.go b/pkg/util/knative/uri_test.go
@@ -88,6 +88,14 @@ func TestChannelUri(t *testing.T) {
 		Name: "default",
 		Kind: "Broker",
 	}, ref)
+
+	ref, err = ExtractObjectReference("knative://event?&brokerApiVersion=eventing.knative.dev/v1beta13&brokxerName=broker2")
+	assert.Nil(t, err)
+	assert.Equal(t, v1.ObjectReference{
+		APIVersion: "eventing.knative.dev/v1beta13",
+		Name:       "default",
+		Kind:       "Broker",
+	}, ref)
 }
 
 func TestNormalizeToUri(t *testing.T) {