Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

155: Make _labels_cost function public #156

Merged
merged 5 commits into from
Mar 7, 2021
Merged

155: Make _labels_cost function public #156

merged 5 commits into from
Mar 7, 2021

Conversation

nicodv
Copy link
Owner

@nicodv nicodv commented Mar 7, 2021

Also:

  • Extracts init methods to own file
  • Makes some functions that should be hidden protected
  • Reorgs files so that public classes/functions are at the top

@nicodv nicodv merged commit 3402a0d into master Mar 7, 2021
@nicodv nicodv deleted the functions-refactor branch March 7, 2021 06:05
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.21% when pulling a8f1162 on functions-refactor into a87e21d on master.

@coveralls
Copy link

coveralls commented Mar 7, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 97.204% when pulling a8f1162 on functions-refactor into a87e21d on master.

@nicodv nicodv mentioned this pull request Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicodv @coveralls