-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't freeze version of packages #49
Comments
After reading https://blog.miguelgrinberg.com/post/the-package-dependency-blues, I've moved to ranges of dependency package versions:
|
scikit-learn has a few more recent versions, could this range be increased? |
@shapiromatron Unfortunately, scikit-learn 0.20 introduces some breaking changes to k-modes. I'm holding off for a bit, but feel free to try it and file a PR. :) |
Thanks @nicodv; I just wanted to make sure it really was required. I'll take a look at see what I can do.... |
What breaks Nico? |
I seem to recall the sklearn compatibility tests have to be rewritten, @trevorstephens : https://github.com/nicodv/kmodes/blob/master/kmodes/tests/test_common.py I've always had to customize that file entirely, because |
Ah yes that makes sense. I saw something vaguely similar from Py-earth in the mailing list saying some of his tests failed due to extra args as well:
You might want to pile onto this PR with some suggestions for your package as was suggested for py-earth: scikit-learn/scikit-learn#8022 |
Please, don't freeze versions of packages
The text was updated successfully, but these errors were encountered: