Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8.0 #79

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Support for PHP 8.0 #79

merged 1 commit into from
Nov 27, 2020

Conversation

pascalbaljet
Copy link
Contributor

No description provided.

@pascalbaljet pascalbaljet marked this pull request as ready for review November 3, 2020 10:58
@freekmurze
Copy link

Hi @nicmart a package of ours is waiting for this package to support PHP 8.0

If possible, could you merge this in soon?

Thank you for your work creating this package 👍

@nicmart
Copy link
Owner

nicmart commented Nov 27, 2020

Hi @freekmurze, I am not the active maintainer of the library anymore.
@localheinz kindly offered to help with the library, so I am redirecting you to him.

@localheinz
Copy link
Collaborator

@freekmurze @nicmart @pascalbaljet

Taking a look later!

👀

@localheinz localheinz self-requested a review November 27, 2020 08:38
@localheinz localheinz self-assigned this Nov 27, 2020
@freekmurze
Copy link

Much appreciated!

I don't want to pressure you in any way, so if you can't find the time, that's ok. I can wait 👍

@localheinz localheinz force-pushed the php-8.0 branch 3 times, most recently from b6d8671 to a91a6a2 Compare November 27, 2020 08:58
@localheinz localheinz merged commit c55ba47 into nicmart:master Nov 27, 2020
@localheinz
Copy link
Collaborator

Thank you, @pascalbaljet!

@freekmurze
Copy link

That was fast! Thanks!

@pascalbaljet
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants