Enhancement: Implement pre- and post-order walkers #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/walker
branch
3 times, most recently
from
efd600a to
7eaa585
Compare
|
Nice, but in the library we already have a traversal for the leaves implemented through a visitor, the YieldVisitor. For consistency I would like to mantain the same pattern. Can you please make the walkers visitors? |
localheinz
force-pushed
the
feature/walker
branch
from
160f322 to
f38f3f3
Compare
localheinz
force-pushed
the
feature/walker
branch
from
1c71312 to
2e86702
Compare
|
👍 Done! |
|
Great, thanks! Tomorrow I'll release a new version with the changes. |
nicmart
added a commit
that referenced
this pull request
Aug 19, 2015
Enhancement: Implement pre- and post-order visitors
This was referenced Aug 20, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Tree\Visitor\PreOrderVisitorwalks a tree in pre-orderTree\Visitor\PostOrderVisitorwalks a tree in post-orderFollows https://twitter.com/localheinz/status/633893849392377856.