forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Vislib replacement toggle (elastic#56439)
* Add new vislib replacement plugin shell * Add config to toggle new vislib replacement
- Loading branch information
1 parent
bd2d76f
commit 836d4a5
Showing
7 changed files
with
385 additions
and
1 deletion.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,173 @@ | ||
# GitHub CODEOWNERS definition | ||
# Identify which groups will be pinged by changes to different parts of the codebase. | ||
# For more info, see https://help.github.com/articles/about-codeowners/ | ||
|
||
# App | ||
/x-pack/legacy/plugins/lens/ @elastic/kibana-app | ||
/x-pack/legacy/plugins/graph/ @elastic/kibana-app | ||
/src/plugins/share/ @elastic/kibana-app | ||
/src/legacy/server/url_shortening/ @elastic/kibana-app | ||
/src/legacy/server/sample_data/ @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/discover/ @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/visualize/ @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/local_application_service/ @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/dev_tools/ @elastic/kibana-app | ||
/src/legacy/core_plugins/metrics/ @elastic/kibana-app | ||
/src/legacy/core_plugins/vis_type_vislib/ @elastic/kibana-app | ||
/src/legacy/core_plugins/vis_type_xy/ @elastic/kibana-app | ||
# Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon | ||
/src/plugins/home/public @elastic/kibana-app | ||
/src/plugins/home/server/*.ts @elastic/kibana-app | ||
/src/plugins/home/server/services/ @elastic/kibana-app | ||
# Exclude tutorial resources folder for now because they are not owned by Kibana app and most will move out soon | ||
/src/legacy/core_plugins/kibana/public/home/*.ts @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/home/*.scss @elastic/kibana-app | ||
/src/legacy/core_plugins/kibana/public/home/np_ready/ @elastic/kibana-app | ||
/src/plugins/kibana_legacy/ @elastic/kibana-app | ||
/src/plugins/timelion/ @elastic/kibana-app | ||
/src/plugins/dev_tools/ @elastic/kibana-app | ||
|
||
# App Architecture | ||
/packages/kbn-interpreter/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/data/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/elasticsearch/lib/create_proxy.js @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/embeddable_api/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/interpreter/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/kibana_react/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/kibana/public/management/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/kibana/server/field_formats/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/kibana/server/routes/api/management/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/kibana/server/routes/api/suggestions/ @elastic/kibana-app-arch | ||
/src/legacy/core_plugins/visualizations/ @elastic/kibana-app-arch | ||
/src/legacy/server/index_patterns/ @elastic/kibana-app-arch | ||
/src/plugins/bfetch/ @elastic/kibana-app-arch | ||
/src/plugins/dashboard_embeddable_container/ @elastic/kibana-app-arch | ||
/src/plugins/data/ @elastic/kibana-app-arch | ||
/src/plugins/embeddable/ @elastic/kibana-app-arch | ||
/src/plugins/expressions/ @elastic/kibana-app-arch | ||
/src/plugins/inspector/ @elastic/kibana-app-arch | ||
/src/plugins/kibana_react/ @elastic/kibana-app-arch | ||
/src/plugins/kibana_utils/ @elastic/kibana-app-arch | ||
/src/plugins/management/ @elastic/kibana-app-arch | ||
/src/plugins/navigation/ @elastic/kibana-app-arch | ||
/src/plugins/ui_actions/ @elastic/kibana-app-arch | ||
/src/plugins/visualizations/ @elastic/kibana-app-arch | ||
/x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch | ||
|
||
# APM | ||
/x-pack/legacy/plugins/apm/ @elastic/apm-ui | ||
/x-pack/plugins/apm/ @elastic/apm-ui | ||
/x-pack/test/functional/apps/apm/ @elastic/apm-ui | ||
/src/legacy/core_plugins/apm_oss/ @elastic/apm-ui | ||
/src/plugins/apm_oss/ @elastic/apm-ui | ||
/src/apm.js @watson | ||
|
||
# Beats | ||
/x-pack/legacy/plugins/beats_management/ @elastic/beats | ||
|
||
# Canvas | ||
/x-pack/legacy/plugins/canvas/ @elastic/kibana-canvas | ||
|
||
# Logs & Metrics UI | ||
/x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui | ||
/x-pack/legacy/plugins/integrations_manager/ @elastic/epm | ||
|
||
# Machine Learning | ||
/x-pack/legacy/plugins/ml/ @elastic/ml-ui | ||
/x-pack/test/functional/apps/machine_learning/ @elastic/ml-ui | ||
/x-pack/test/functional/services/machine_learning/ @elastic/ml-ui | ||
/x-pack/test/functional/services/ml.ts @elastic/ml-ui | ||
# ML team owns the transform plugin, ES team added here for visibility | ||
# because the plugin lives in Kibana's Elasticsearch management section. | ||
/x-pack/legacy/plugins/transform/ @elastic/ml-ui @elastic/es-ui | ||
/x-pack/test/functional/apps/transform/ @elastic/ml-ui | ||
/x-pack/test/functional/services/transform_ui/ @elastic/ml-ui | ||
/x-pack/test/functional/services/transform.ts @elastic/ml-ui | ||
|
||
# Maps | ||
/x-pack/legacy/plugins/maps/ @elastic/kibana-gis | ||
/x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis | ||
/x-pack/test/functional/apps/maps/ @elastic/kibana-gis | ||
/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis | ||
/x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis | ||
|
||
# Operations | ||
/src/dev/ @elastic/kibana-operations | ||
/src/setup_node_env/ @elastic/kibana-operations | ||
/src/optimize/ @elastic/kibana-operations | ||
/src/es_archiver/ @elastic/kibana-operations | ||
/packages/*eslint*/ @elastic/kibana-operations | ||
/packages/*babel*/ @elastic/kibana-operations | ||
/packages/kbn-dev-utils*/ @elastic/kibana-operations | ||
/packages/kbn-es/ @elastic/kibana-operations | ||
/packages/kbn-pm/ @elastic/kibana-operations | ||
/packages/kbn-test/ @elastic/kibana-operations | ||
/packages/kbn-ui-shared-deps/ @elastic/kibana-operations | ||
/src/legacy/server/keystore/ @elastic/kibana-operations | ||
/src/legacy/server/pid/ @elastic/kibana-operations | ||
/src/legacy/server/sass/ @elastic/kibana-operations | ||
/src/legacy/server/utils/ @elastic/kibana-operations | ||
/src/legacy/server/warnings/ @elastic/kibana-operations | ||
|
||
# Platform | ||
/src/core/ @elastic/kibana-platform | ||
/config/kibana.yml @elastic/kibana-platform | ||
/x-pack/plugins/features/ @elastic/kibana-platform | ||
/x-pack/plugins/licensing/ @elastic/kibana-platform | ||
/packages/kbn-config-schema/ @elastic/kibana-platform | ||
/src/legacy/server/config/ @elastic/kibana-platform | ||
/src/legacy/server/http/ @elastic/kibana-platform | ||
/src/legacy/server/i18n/ @elastic/kibana-platform | ||
/src/legacy/server/logging/ @elastic/kibana-platform | ||
/src/legacy/server/saved_objects/ @elastic/kibana-platform | ||
/src/legacy/server/status/ @elastic/kibana-platform | ||
/src/dev/run_check_core_api_changes.ts @elastic/kibana-platform | ||
|
||
# Security | ||
/src/core/server/csp/ @elastic/kibana-security @elastic/kibana-platform | ||
/x-pack/legacy/plugins/security/ @elastic/kibana-security | ||
/x-pack/legacy/plugins/spaces/ @elastic/kibana-security | ||
/x-pack/plugins/spaces/ @elastic/kibana-security | ||
/x-pack/legacy/plugins/encrypted_saved_objects/ @elastic/kibana-security | ||
/x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security | ||
/x-pack/plugins/security/ @elastic/kibana-security | ||
/x-pack/test/api_integration/apis/security/ @elastic/kibana-security | ||
|
||
# Kibana Localization | ||
/src/dev/i18n/ @elastic/kibana-localization | ||
|
||
# Pulse | ||
/packages/kbn-analytics/ @elastic/pulse | ||
/src/legacy/core_plugins/ui_metric/ @elastic/pulse | ||
/src/plugins/usage_collection/ @elastic/pulse | ||
/x-pack/legacy/plugins/telemetry/ @elastic/pulse | ||
|
||
# Kibana Alerting Services | ||
/x-pack/legacy/plugins/alerting/ @elastic/kibana-alerting-services | ||
/x-pack/legacy/plugins/actions/ @elastic/kibana-alerting-services | ||
/x-pack/plugins/event_log/ @elastic/kibana-alerting-services | ||
/x-pack/plugins/task_manager/ @elastic/kibana-alerting-services | ||
/x-pack/test/alerting_api_integration/ @elastic/kibana-alerting-services | ||
/x-pack/test/plugin_api_integration/plugins/task_manager/ @elastic/kibana-alerting-services | ||
/x-pack/test/plugin_api_integration/test_suites/task_manager/ @elastic/kibana-alerting-services | ||
/x-pack/legacy/plugins/triggers_actions_ui/ @elastic/kibana-alerting-services | ||
/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/ @elastic/kibana-alerting-services | ||
/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/ @elastic/kibana-alerting-services | ||
|
||
# Design | ||
**/*.scss @elastic/kibana-design | ||
|
||
# Elasticsearch UI | ||
/src/plugins/console/ @elastic/es-ui | ||
/src/plugins/es_ui_shared/ @elastic/es-ui | ||
/x-pack/plugins/console_extensions/ @elastic/es-ui | ||
/x-pack/legacy/plugins/cross_cluster_replication/ @elastic/es-ui | ||
/x-pack/legacy/plugins/index_lifecycle_management/ @elastic/es-ui | ||
/x-pack/legacy/plugins/index_management/ @elastic/es-ui | ||
/x-pack/legacy/plugins/license_management/ @elastic/es-ui | ||
/x-pack/legacy/plugins/remote_clusters/ @elastic/es-ui | ||
/x-pack/legacy/plugins/rollup/ @elastic/es-ui | ||
/x-pack/plugins/searchprofiler/ @elastic/es-ui | ||
/x-pack/legacy/plugins/snapshot_restore/ @elastic/es-ui | ||
/x-pack/plugins/watcher/ @elastic/es-ui |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,4 +50,4 @@ | |
"src/legacy/ui/ui_render/ui_render_mixin.js" | ||
], | ||
"translations": [] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { resolve } from 'path'; | ||
import { Legacy } from 'kibana'; | ||
|
||
import { LegacyPluginApi, LegacyPluginInitializer } from '../../types'; | ||
|
||
export interface ConfigSchema { | ||
visTypeXy: { | ||
enabled: boolean; | ||
}; | ||
} | ||
|
||
const visTypeXyPluginInitializer: LegacyPluginInitializer = ({ Plugin }: LegacyPluginApi) => | ||
new Plugin({ | ||
id: 'visTypeXy', | ||
require: ['kibana', 'elasticsearch', 'visualizations', 'interpreter', 'data'], | ||
publicDir: resolve(__dirname, 'public'), | ||
uiExports: { | ||
hacks: [resolve(__dirname, 'public/legacy')], | ||
injectDefaultVars(server): ConfigSchema { | ||
const config = server.config(); | ||
|
||
return { | ||
visTypeXy: { | ||
enabled: config.get('visTypeXy.enabled') as boolean, | ||
}, | ||
}; | ||
}, | ||
}, | ||
config(Joi: any) { | ||
return Joi.object({ | ||
enabled: Joi.boolean().default(false), | ||
}).default(); | ||
}, | ||
} as Legacy.PluginSpecOptions); | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export default visTypeXyPluginInitializer; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "visTypeXy", | ||
"version": "kibana" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { PluginInitializerContext } from '../../../../core/public'; | ||
import { VisTypeXyPlugin as Plugin } from './plugin'; | ||
|
||
export function plugin(initializerContext: PluginInitializerContext) { | ||
return new Plugin(initializerContext); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { npSetup, npStart } from 'ui/new_platform'; | ||
import { PluginInitializerContext } from 'kibana/public'; | ||
|
||
import { plugin } from '.'; | ||
import { VisTypeXyPluginSetupDependencies, VisTypeXyPluginStartDependencies } from './plugin'; | ||
import { | ||
setup as visualizationsSetup, | ||
start as visualizationsStart, | ||
} from '../../visualizations/public/np_ready/public/legacy'; | ||
|
||
const setupPlugins: Readonly<VisTypeXyPluginSetupDependencies> = { | ||
expressions: npSetup.plugins.expressions, | ||
visualizations: visualizationsSetup, | ||
charts: npSetup.plugins.charts, | ||
}; | ||
|
||
const startPlugins: Readonly<VisTypeXyPluginStartDependencies> = { | ||
expressions: npStart.plugins.expressions, | ||
visualizations: visualizationsStart, | ||
}; | ||
|
||
const pluginInstance = plugin({} as PluginInitializerContext); | ||
|
||
export const setup = pluginInstance.setup(npSetup.core, setupPlugins); | ||
export const start = pluginInstance.start(npStart.core, startPlugins); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { | ||
CoreSetup, | ||
CoreStart, | ||
Plugin, | ||
IUiSettingsClient, | ||
PluginInitializerContext, | ||
} from 'kibana/public'; | ||
|
||
import { Plugin as ExpressionsPublicPlugin } from '../../../../plugins/expressions/public'; | ||
import { VisualizationsSetup, VisualizationsStart } from '../../visualizations/public'; | ||
import { ChartsPluginSetup } from '../../../../plugins/charts/public'; | ||
|
||
export interface VisTypeXyDependencies { | ||
uiSettings: IUiSettingsClient; | ||
charts: ChartsPluginSetup; | ||
} | ||
|
||
/** @internal */ | ||
export interface VisTypeXyPluginSetupDependencies { | ||
expressions: ReturnType<ExpressionsPublicPlugin['setup']>; | ||
visualizations: VisualizationsSetup; | ||
charts: ChartsPluginSetup; | ||
} | ||
|
||
/** @internal */ | ||
export interface VisTypeXyPluginStartDependencies { | ||
expressions: ReturnType<ExpressionsPublicPlugin['start']>; | ||
visualizations: VisualizationsStart; | ||
} | ||
|
||
type VisTypeXyCoreSetup = CoreSetup<VisTypeXyPluginStartDependencies>; | ||
|
||
/** @internal */ | ||
export class VisTypeXyPlugin implements Plugin<Promise<void>, void> { | ||
constructor(public initializerContext: PluginInitializerContext) {} | ||
|
||
public async setup( | ||
core: VisTypeXyCoreSetup, | ||
{ expressions, visualizations, charts }: VisTypeXyPluginSetupDependencies | ||
) { | ||
// eslint-disable-next-line no-console | ||
console.warn( | ||
'The visTypeXy plugin is enabled\n\n', | ||
'This may negatively alter existing vislib visualization configurations if saved.' | ||
); | ||
const visualizationDependencies: Readonly<VisTypeXyDependencies> = { | ||
uiSettings: core.uiSettings, | ||
charts, | ||
}; | ||
|
||
const visTypeDefinitions: any[] = []; | ||
const visFunctions: any = []; | ||
|
||
visFunctions.forEach((fn: any) => expressions.registerFunction(fn)); | ||
visTypeDefinitions.forEach((vis: any) => | ||
visualizations.types.createBaseVisualization(vis(visualizationDependencies)) | ||
); | ||
} | ||
|
||
public start(core: CoreStart, deps: VisTypeXyPluginStartDependencies) { | ||
// nothing to do here | ||
} | ||
} |