Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the Windows installer for arm64 as well #1839

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Aug 27, 2024

Fixes #1834

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (8407445) to head (cdb8cc8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
- Coverage   95.34%   94.76%   -0.59%     
==========================================
  Files          20       20              
  Lines       17978    17978              
==========================================
- Hits        17141    17036     -105     
- Misses        837      942     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicklockwood nicklockwood merged commit b58cf01 into nicklockwood:main Aug 31, 2024
10 of 11 checks passed
@nicklockwood
Copy link
Owner

@tristanlabelle there seems to be a problem with the arm64 build: https://github.com/nicklockwood/SwiftFormat/actions/runs/10746115398/job/29806432973

@tristanlabelle
Copy link
Contributor Author

@nicklockwood ah sorry, workflows are hard to test for contributors. Here's the fix: #1848

@tristanlabelle tristanlabelle deleted the windows-arm64 branch September 7, 2024 20:08
@nicklockwood
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and release an arm64 installer on Windows
2 participants