Refactor Response API and trim NickelError #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… harder The majority of the Response api now returns a MiddlewareResult. [breaking-change]
Additionally rename `status_code` to `set_status` and introduce `status` to access the current status code for a `Response`. [breaking-change]
|
Nice! Does @cburgdorf or @rgs1 have an opinion on this and #168? |
Merged
|
Taking a look now |
|
Nice work @Ryman :-) Left some comments/nits with each commit - will do a 2nd pass tomorrow. |
|
Currently blocked on hyper, will push up edits once I know they compile! |
|
Last commit has some rust/hyper changes and addresses @rgs1's feedback. |
|
Sweet - thanks @Ryman. Will look at it in a bit. |
|
generally lgtm, i'd merge and we can keep iterating from there |
|
@simonpersson good to merge? |
|
Yes, go ahead and merge :) |
Ryman
added a commit
that referenced
this pull request
Mar 24, 2015
Refactor Response API and trim NickelError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #168.
Providing a separate PR incase the design isn't agreeable (this is based on that branch).
These changes make it easier to enforce standard behavior. HTTP doesn't really allow changing the status code once a response is already in progress, so users should either bail (and log) or start an error with an appropriate code which error handlers can process.
I considered changing the API for an ErrorHandler to take
&mut Option<Response<Streaming>>but decided to keepNickelErroras in the absense of aResponsewe can at least still know what the developers error message was (in case they want to log something to a database rather than nothing).