Skip to content

Commit

Permalink
Always use html.parser for bs4 prettify in test comparisons
Browse files Browse the repository at this point in the history
  • Loading branch information
@nickderobertis
nickderobertis committed Oct 8, 2022
1 parent 3930f8f commit a76c860
Show file tree
Hide file tree
Showing 4 changed files with 160 additions and 178 deletions.
2 changes: 1 addition & 1 deletion tests/base.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def assert_styled_matches(styler: Styler, file_path: str = DF_STYLED_PATH, gener


def _prettify_html(html: str) -> str:
soup = BeautifulSoup(html)
soup = BeautifulSoup(html, "html.parser")
return soup.prettify()


Expand Down
112 changes: 53 additions & 59 deletions tests/input_data/df_labeled.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<html>
<head>
<style type="text/css">
#T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0 {
<style type="text/css">
#T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0 {
background-color: #a50026;
color: #f1f1f1;
}
Expand All @@ -13,58 +11,54 @@
background-color: #006837;
color: #f1f1f1;
}
</style>
</head>
<body>
<table id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad">
<caption>
my_res - Formatted 1 vs. Formatted 2
</caption>
<thead>
<tr>
<th class="blank level0">
</th>
<th class="col_heading level0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col0">
4
</th>
<th class="col_heading level0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col1">
5
</th>
</tr>
<tr>
<th class="index_name level0">
Formatted 1
</th>
<th class="blank col0">
</th>
<th class="blank col1">
</th>
</tr>
</thead>
<tbody>
<tr>
<th class="row_heading level0 row0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row0">
1
</th>
<td class="data row0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0">
10.000000
</td>
<td class="data row0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col1">
11.000000
</td>
</tr>
<tr>
<th class="row_heading level0 row1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row1">
2
</th>
<td class="data row1 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col0">
11.000000
</td>
<td class="data row1 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col1">
12.000000
</td>
</tr>
</tbody>
</table>
</body>
</html>
</style>
<table id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad">
<caption>
my_res - Formatted 1 vs. Formatted 2
</caption>
<thead>
<tr>
<th class="blank level0">
</th>
<th class="col_heading level0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col0">
4
</th>
<th class="col_heading level0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col1">
5
</th>
</tr>
<tr>
<th class="index_name level0">
Formatted 1
</th>
<th class="blank col0">
</th>
<th class="blank col1">
</th>
</tr>
</thead>
<tbody>
<tr>
<th class="row_heading level0 row0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row0">
1
</th>
<td class="data row0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0">
10.000000
</td>
<td class="data row0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col1">
11.000000
</td>
</tr>
<tr>
<th class="row_heading level0 row1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row1">
2
</th>
<td class="data row1 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col0">
11.000000
</td>
<td class="data row1 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col1">
12.000000
</td>
</tr>
</tbody>
</table>
112 changes: 53 additions & 59 deletions tests/input_data/df_styled.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<html>
<head>
<style type="text/css">
#T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0 {
<style type="text/css">
#T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0 {
background-color: #a50026;
color: #f1f1f1;
}
Expand All @@ -13,58 +11,54 @@
background-color: #006837;
color: #f1f1f1;
}
</style>
</head>
<body>
<table id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad">
<caption>
my_res - value1 vs. value2
</caption>
<thead>
<tr>
<th class="blank level0">
</th>
<th class="col_heading level0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col0">
4
</th>
<th class="col_heading level0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col1">
5
</th>
</tr>
<tr>
<th class="index_name level0">
value1
</th>
<th class="blank col0">
</th>
<th class="blank col1">
</th>
</tr>
</thead>
<tbody>
<tr>
<th class="row_heading level0 row0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row0">
1
</th>
<td class="data row0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0">
10.000000
</td>
<td class="data row0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col1">
11.000000
</td>
</tr>
<tr>
<th class="row_heading level0 row1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row1">
2
</th>
<td class="data row1 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col0">
11.000000
</td>
<td class="data row1 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col1">
12.000000
</td>
</tr>
</tbody>
</table>
</body>
</html>
</style>
<table id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad">
<caption>
my_res - value1 vs. value2
</caption>
<thead>
<tr>
<th class="blank level0">
</th>
<th class="col_heading level0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col0">
4
</th>
<th class="col_heading level0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col1">
5
</th>
</tr>
<tr>
<th class="index_name level0">
value1
</th>
<th class="blank col0">
</th>
<th class="blank col1">
</th>
</tr>
</thead>
<tbody>
<tr>
<th class="row_heading level0 row0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row0">
1
</th>
<td class="data row0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0">
10.000000
</td>
<td class="data row0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col1">
11.000000
</td>
</tr>
<tr>
<th class="row_heading level0 row1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row1">
2
</th>
<td class="data row1 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col0">
11.000000
</td>
<td class="data row1 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col1">
12.000000
</td>
</tr>
</tbody>
</table>
112 changes: 53 additions & 59 deletions tests/input_data/df_styled_num_fmt.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<html>
<head>
<style type="text/css">
#T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0 {
<style type="text/css">
#T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0 {
background-color: #a50026;
color: #f1f1f1;
}
Expand All @@ -13,58 +11,54 @@
background-color: #006837;
color: #f1f1f1;
}
</style>
</head>
<body>
<table id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad">
<caption>
my_res - value1 vs. value2
</caption>
<thead>
<tr>
<th class="blank level0">
</th>
<th class="col_heading level0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col0">
4
</th>
<th class="col_heading level0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col1">
5
</th>
</tr>
<tr>
<th class="index_name level0">
value1
</th>
<th class="blank col0">
</th>
<th class="blank col1">
</th>
</tr>
</thead>
<tbody>
<tr>
<th class="row_heading level0 row0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row0">
1
</th>
<td class="data row0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0">
$10
</td>
<td class="data row0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col1">
$11
</td>
</tr>
<tr>
<th class="row_heading level0 row1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row1">
2
</th>
<td class="data row1 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col0">
$11
</td>
<td class="data row1 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col1">
$12
</td>
</tr>
</tbody>
</table>
</body>
</html>
</style>
<table id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad">
<caption>
my_res - value1 vs. value2
</caption>
<thead>
<tr>
<th class="blank level0">
</th>
<th class="col_heading level0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col0">
4
</th>
<th class="col_heading level0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_col1">
5
</th>
</tr>
<tr>
<th class="index_name level0">
value1
</th>
<th class="blank col0">
</th>
<th class="blank col1">
</th>
</tr>
</thead>
<tbody>
<tr>
<th class="row_heading level0 row0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row0">
1
</th>
<td class="data row0 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col0">
$10
</td>
<td class="data row0 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row0_col1">
$11
</td>
</tr>
<tr>
<th class="row_heading level0 row1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_level0_row1">
2
</th>
<td class="data row1 col0" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col0">
$11
</td>
<td class="data row1 col1" id="T_1ee5ad65-4cac-42e3-8133-7ae800cb23ad_row1_col1">
$12
</td>
</tr>
</tbody>
</table>

0 comments on commit a76c860

Please sign in to comment.