feat: add support for GCS #21
Conversation
There was a problem hiding this comment.
Thank you for the pull request, @nawfel-bacha! Adding GCS support will be a boon for folks using GCP, and I'll be able to use this as a baseline for S3 support.
I left a few comments on this PR around types and terminology. As always, this is intended to spark discussion more than anything else. Please let me know if the requested changes make sense and align with your use case.
Lastly, note that this repo is configured with pre-commit to enforce format, linting, and type checks. Please verify that your development environment is leveraging these pre-commit checks, so our changes are consistent.
|
@nicholasyager Thanks for the feedback, I made the necessary changes, feel free to check it out! |
dbt_loom/__init__.py
Outdated
| identifier=node.get("relation_name").split(".")[-1].replace('"', ""), | ||
| identifier=node.get("relation_name").split(".")[-1].replace('"', "").replace('`',""), |
There was a problem hiding this comment.
Fixed a bug where the identifier would have double backticks.
There was a problem hiding this comment.
@nawfel-bacha This is very nearly there! I left a couple comments around documentation. Once those are resolved, we'll be good to merge this in and cut a new release!
There was a problem hiding this comment.
@nawfel-bacha Thanks for the changes! This PR is good to go 🚀
Added support for loading manifest file from a GCS bucket.
Example of dbt_loom.config.yml:
Example of a dbt run:
Resolves: #20