Fix for Tx writes not being valid when multiple instances of custom device exist #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Check Previous Values.vi.png
Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png
|
buckd
approved these changes
Jun 13, 2024
Source/Custom Device Support/Engine/Implementation/Tx Execution Unit/Check Previous Values.vi
Show resolved
Hide resolved
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Check Previous Values.vi.png
Ballard MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Forces each Tx Execution Unit class to store its own copy of previous data values. The current implementation shares data space across all Tx Execution Units due to the requirement that reentrant dynamic dispatch VIs be shared reentrant.
Adds a VI Check Previous Values.vi to compare the data values
Each execution unit calls Check Previous Values.vi in Write to Hardware.vi so the check is actually valid against the last iteration of that execution unit and the data used for whichever execution unit ran last.
Why should this Pull Request be merged?
Fix for #253
What testing has been done?
Ran all the unit tests. Manually tested that multiple instances are working as expected in RT target.
