Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaferMap component - basic storybook implementation #834
WaferMap component - basic storybook implementation #834
Changes from 5 commits
efd6489
6d22606
b7e405f
854667e
22763eb
73bd0ad
f2d5b0a
3bd4b21
cbd63a4
e9d03cf
dc47172
51b0383
34e8018
9a72e98
dcf2963
9538e9a
1dd13c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a name: configuration that uses the attribute name for these args, ie
name: 'max-characters'
. Similar to the above it allows it to map more closely to the HTML representation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DStavilaNI I think there was a misunderstanding. The goal is so the names in the story align with the names in the user html example:
Currently the html that is rendered is also incorrect:
I'd expect the attribute names in storybook to look like
max-characters
as my comment described and notmaxcharacters
as your change shows. For such a big deviation from comments it may be worth asking for a clarification.The expected HTML is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of revertting the changes in the PR I created the following issue: #836
Those changes need to be addressed for others to build on the storybook changes.