Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spright-chat-conversation and spright-chat-message components #2529

Merged
merged 68 commits into from
Feb 14, 2025

Conversation

joseahdz
Copy link
Contributor

@joseahdz joseahdz commented Jan 30, 2025

Pull Request

🤨 Rationale

Some Intelligent Test application teams need to create a chat interface. The chat interface will be shared by all those teams. The chat interface will be built using Blazor and Nimble components. In this PR, I am adding two Nimble components spright-chat-conversation and spright-chat-message components that will be used in the chat interface.

The spec detailing the new components is here #2513.

👩‍💻 Implementation

  1. Added spright components spright-chat-conversation and spright-chat-message components.
  2. Added storybook documentation and updated component status table to include components in a new Spright category

🧪 Testing

Added some tests, story and theme matrix

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@joseahdz joseahdz requested a review from fredvisser as a code owner February 6, 2025 00:13
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not finished reviewing but this is some initial feedback. Providing it sooner so it can be addressed sooner but as discussed I plan to finish review early next week.

@rajsite rajsite merged commit 772266a into main Feb 14, 2025
12 checks passed
@rajsite rajsite deleted the spright-chat-components-final branch February 14, 2025 03:47
@joseahdz joseahdz mentioned this pull request Feb 14, 2025
1 task
rajsite pushed a commit that referenced this pull request Feb 18, 2025
# Pull Request

## 🤨 Rationale

Adding Blazor wrappers for Spright chat-components.

Spright chat-components were submitted in this PR #2529.

## 👩‍💻 Implementation

Added Blazor wrappers under SprightBlazor folder.

## 🧪 Testing

Added unit tests and all passed.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Jose A. Hernandez <jose.a.hernandez@ni.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants