-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spright-chat-conversation and spright-chat-message components #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
approved these changes
Feb 5, 2025
jattasNI
approved these changes
Feb 6, 2025
jattasNI
reviewed
Feb 6, 2025
rajsite
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not finished reviewing but this is some initial feedback. Providing it sooner so it can be addressed sooner but as discussed I plan to finish review early next week.
rajsite
reviewed
Feb 12, 2025
rajsite
reviewed
Feb 13, 2025
rajsite
approved these changes
Feb 14, 2025
rajsite
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Some Intelligent Test application teams need to create a chat interface. The chat interface will be shared by all those teams. The chat interface will be built using Blazor and Nimble components. In this PR, I am adding two Nimble components spright-chat-conversation and spright-chat-message components that will be used in the chat interface.
The spec detailing the new components is here #2513.
👩💻 Implementation
🧪 Testing
Added some tests, story and theme matrix
✅ Checklist