Create Angular mixins for fractional-width columns and groupable columns #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmgrifter00
approved these changes
Oct 5, 2023
rajsite
approved these changes
Oct 5, 2023
This was referenced Oct 6, 2023
rajsite
added a commit
that referenced
this pull request
Oct 6, 2023
…ble columns (#1591) # Pull Request ## 🤨 Rationale Turns out the pattern introduced in #1587 for [using TypeScript mixins does not work for Angular directives](angular/angular#42594 (comment)) and resulted in [build failures for a built library used outside the workspace](https://dev.azure.com/ni/DevCentral/_build/results?buildId=6361598&view=logs&j=5cb0c4d9-f36d-5fb3-bf2e-85320ef8bd68&t=51824763-f056-5c1e-0120-b664705fb575&l=71). Reading the linked comment it sounds like we are seeing the exact behavior described. `@Input` bindings used in the base class (column-id) are failing to resolve. Even the extra sinister part where it works in the workspace (our tests do [test bindings to base class props like column-id](https://github.com/ni/nimble/blob/main/angular-workspace/projects/ni/nimble-angular/table-column/anchor/tests/nimble-table-column-anchor.directive.spec.ts#L169)) but not in apps using the published library 😵. ## 👩💻 Implementation Revert the refactor ## 🧪 Testing Rely on CI ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. Nada
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Resolves #1211
In Angular, we didn't have a solution for the code duplication that came with multiple columns being fractional width and groupable. This PR creates mixins for fractional width columns and groupable columns to reduce the amount of duplication. There is still the potential for future code reduction within the tests, but I decided that coming up to a solution single-sourcing more of our test code was out of scope for this PR.
👩💻 Implementation
mixinFractionalWidthColumnAPIfunction that allows aNimbleTableColumnBaseDirectiveto claim support for being fractional width (i.e. inputs forfractionalWidthandminPixelWidth). This function is exported from the existing@ni/nimble-angular/table-columnentry point.mixinGroupableColumnAPIfunction that allows aNimbleTableColumnBaseDirectiveto claim support for being groupable (i.e. inputs forgroupIndexandgroupingDisabled). This function is exported from the existing@ni/nimble-angular/table-columnentry point.rendererandelementRefpublic (though marked as internal) inNimbleTableColumnBaseDirectivebecause otherwise TS error 4094 is triggered. This is related to themixinFractionalWidthColumnAPIandmixinGroupableColumnAPIfunctions having an implicit return type and that inferred type includingNimbleTableColumnBaseDirective. The scenario I was hitting is described in this TypeScript issue.🧪 Testing
✅ Checklist