Support an array of XY data plots #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
requested review from
csjall,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
|
@bkeryan I need your review on this one. |
bkeryan
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
AB#2661726
Fixes #626
It is desired to support an array of XY plots. This PR updates message serialization and deserialization to support repeated messages.
Why should this Pull Request be merged?
Allow a dynamic number of XY plots to be returned, e.g. from a Scope where the number of channels / pins measured varies per run of the measurement.
What testing has been done?
Added auto-tests for DoubleXYDataArray1D. Modified the Game of Life example (locally only, not submitting) to have multiple games running on the same graph. Multiple plots only works on a LabVIEW UI at this time, so I borrowed the LabVIEW UI from the LabVIEW example and tweaked it to work.