Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix duplicate test parameters #597

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Jan 29, 2024

What does this Pull Request accomplish?

Delete duplicate test parameters and fix spelling.

Why should this Pull Request be merged?

The upgrade to Pytest 8.0 highlighted these by changing how they are formatted:

#596

What testing has been done?

PR build

The upgrade to Pytest 8.0 highlighted these by changing how they are formatted:

#596
Copy link

Test Results

    30 files  ± 0      30 suites  ±0   36m 1s ⏱️ - 3m 0s
   557 tests  -  1     556 ✅  -  1      1 💤 ±0  0 ❌ ±0 
13 690 runs   - 30  12 620 ✅  - 30  1 070 💤 ±0  0 ❌ ±0 

Results for commit 71661b6. ± Comparison against base commit 0c03db5.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
tests.unit.test_service ‑ test___measurement_service___add_output__output_added[UInt44-DataType.UInt640]
tests.unit.test_service ‑ test___measurement_service___add_output__output_added[UInt44-DataType.UInt641]
tests.unit.test_service ‑ test___measurement_service___add_output__output_added[UInt64-DataType.UInt64]

@bkeryan bkeryan merged commit bb1ce67 into main Jan 29, 2024
17 checks passed
@bkeryan bkeryan deleted the users/bkeryan/fix-duplicate-test-params branch January 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants