Pulse Initial Service Changes #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
maxxboehme
requested changes
Oct 15, 2024
reckenro
reviewed
Oct 15, 2024
reckenro
approved these changes
Oct 15, 2024
ThangamV-NI
approved these changes
Oct 16, 2024
Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>
maxxboehme
approved these changes
Oct 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adding files for Pulse Initial Service
Why should this Pull Request be merged?
We want to add gRPC API support for RFmx Pulse personality
What testing has been done?
I have posted PR for adding Pulse installers to the gtest job. Here is the link: https://dev.azure.com/ni/DevCentral/_git/ni-central/pullrequest/816126.
The Pulse tests are running successfully without any errors: