Split API addition for SpecAn Personality #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
ThangamV-NI
approved these changes
Sep 13, 2024
astarche
approved these changes
Sep 13, 2024
reckenro
approved these changes
Sep 13, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adding Split APIs for niRFmxSpecAn personality as part of the WI: https://dev.azure.com/ni/DevCentral/_workitems/edit/2820766
The metadata required for these APIs are generated as part of PR: https://github.com/ni/grpc-device-scrapigen/pull/239
Why should this Pull Request be merged?
This API support in gRPC was requested as part of the WI: https://dev.azure.com/ni/DevCentral/_workitems/edit/2820766
There is a need for adding Split APIs as a part of our gRPC APIs as the corresponding APIs which uses Complex datatype are taking more time to execute than expected. The reason for this is because of the extra time consumed while implicitly converting the Complex Datatype into real and imaginary part.
But if the user can use Split API, they can directly pass the real and imaginary values and avoid the extra time of implicit conversion.
What testing has been done?
Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxspecan/export/ to grpc-device/source/codegen/metadata/nirfmxspecan/ and built grpc-device successfully.
Manually inspected nirfmxspecan.proto file.
It is adding only the entries for Split APIs and neither modifying the existing entries nor adding any new entries.