VNA Initial Service Changes #1077
Conversation
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
|
I am facing issues while running the newly added VNA Test cases. I have followed the #481 PR to add the files. Am I doing anything wrong? Please help me debug this issue. |
Does this require a new product to be installed? If so need to update the products to install to grpcbot (The system that runs the system tests) |
I have added the installers for VNA through this PR: link Yet I am facing a new issue while triggering the gtests in windows environment. Here is the error message: I tried re-running only the failed job and that also failed. Now I have re-running the whole ci. If that also fails, is there anything I can do to fix this? |
|
@RahulBenaka I kicked off a pipeline run that should rebuild the image used for running the tests. It needs to be rebuilt to include your changes. The error you are getting currently is because the artifacts are deleted after a few days so you will need to rerun all the steps to recreate the artifacts. |
Pipeline just finished. I will kick off another run for windows. Ubuntu is currently in a bad state that I am looking into so can be ignored for now. |
There was a problem hiding this comment.
Changes look fine to me.
@RahulBenaka , did you generate the metadata in scrapigen and if so can you post a PR there for that?
I haven't done any changes there as this is the initial setup for VNA personality. Once this goes in, I'll post a separate PR for scrapigen generated metadata. |
|
Update the TODO in the "What testing has been done?" section |
|
I have updated the description section @maxxboehme. If the changes are good, can you please approve the PR? |
What does this Pull Request accomplish?
Adding files for VNA Initial Service
Why should this Pull Request be merged?
We want to add gRPC API support for RFmx VNA personality
What testing has been done?
Builds and new System-level tests pass.