Updated gRPC Device code for BT, LTE and SpecAn 24C2 Cycle RFmx APIs #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
ThangamV-NI
reviewed
May 7, 2024
ThangamV-NI
reviewed
May 7, 2024
astarche
reviewed
May 7, 2024
reckenro
reviewed
May 7, 2024
reckenro
requested changes
May 7, 2024
reckenro
reviewed
May 7, 2024
RahulBenaka
added
binary-breaking
reckenro
approved these changes
May 8, 2024
maxxboehme
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates niRFmxSpecAn in grpc-device-scrapigen to 24.5.0
Updates niRFmxLTE in grpc-device-scrapigen to 24.5.0
Updates niRFmxBT in grpc-device-scrapigen to 24.5.0
Updates the gRPC Scrapigen Device Code for SpecAn APIs which are created for the specific feature request from the customer: Addition of Sequential FFT to Spectrum measurement with configurable overlap type property.
Updates the gRPC Scrapigen Device Code for LTE TXP measurement APIs, attributes and enums.
Updates the gRPC Scrapigen Device Code for new BT enum value for an attribute.
Why should this Pull Request be merged?
Updated to match the upcoming release of niRFmxSpecAn 24.5.0
Updated to match the upcoming release of niRFmxLTE 24.5.0
Updated to match the upcoming release of niRFmxBT 24.5.0
What testing has been done?
Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxspecan/export/ to grpc-device/source/codegen/metadata/nirfmxspecan/ and built grpc-device successfully.
Manually inspected nirfmxspecan.proto file.
Copied files from grpc-device-scrapigen/out/rfmxlte/export/ to grpc-device/source/codegen/metadata/nirfmxlte/ and built grpc-device successfully.
Manually inspected nirfmxlte.proto file.
Copied files from grpc-device-scrapigen\out\rfmxbluetooth\export to grpc-device/source/codegen/metadata/ nirfmxbluetooth / and built grpc-device successfully.
Manually inspected nirfmxbluetooth.proto file.
Breaking Changes
RFmx SpecAn: removing
timeoutfield fromMarkerFetchFunctionValueRequestto match Driver API. Technically breaking for grpc-device but this method was busted in grpc-device in the previous release because the C API never released with the timeout parameter, and those changes weren’t carried over to grpc-device.