Save some additional memory allocations #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
force-pushed
the
nh-fix-disabled-inputs-save-allocations
branch
from
1d8a89b
to
8bf84ea
Compare
| // Make sure we set .type before any other properties (setting .value | ||
| // before .type means .value is lost in IE11 and below) | ||
| type: undefined, | ||
| }, DisabledInputUtils.getNativeProps(inst, props), { |
There was a problem hiding this comment.
I'm keeping this { type: undefined } default for now, but is this relying on key insertion order? If not, could we replace this with something later like:
// Make sure we set .type, otherwise .value is lost in IE11 and below
nativeProps.type = nativeProps.type == null ? undefined: nativeProps;If this isn't the case, we could save another allocation per input.
| if (!props.disabled) { | ||
| return props; | ||
| assignWithNativeProps: function(a,b,c,d,e,f,g) { | ||
| invariant(!g, 'assignWithNativeProps only accepts 6 arguments'); |
There was a problem hiding this comment.
This doesn't feel awesome, but I wanted to lean on assign as before and didn't want to slice arguments into another allocation.
nhunzaker
force-pushed
the
nh-fix-disabled-inputs-save-allocations
branch
from
8bf84ea
to
6e97642
Compare
nhunzaker
pushed a commit
that referenced
this pull request
Jul 15, 2016
Improve symbol check for (local) polyfills
nhunzaker
pushed a commit
that referenced
this pull request
Nov 29, 2016
nhunzaker
pushed a commit
that referenced
this pull request
Aug 10, 2017
* Remove PooledClass from FallbackCompositionState The only module that uses FallbackCompositonState is BeforeInputEventPlugin. The way its structured means there can only be a single instance of FallbackCompositionState at any given time (stored in a local variable at the top-level) so we don't really need pooling here at all. Instead, a single object is now stored in FallbackCompositionState, and access (initializing, reseting, getting data) is gaurded by the exported helper object. * Use new FallbackCompositionState API in BeforeInputEventPlugin * Implement event-specific pooling in SyntheticEvent * Remove PooledClass from TopLevelCallbackBookKeeping * Update results.json * Add pooled event test fixtures (#1) * Fix fixture lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.