Migrate over rules for DOM Fiber. Update tests

nhunzaker · Nov 20, 2016 · 96b72d0 · 96b72d0
1 parent 2c405dd
commit 96b72d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/scripts/fiber/tests-passing-except-dev.txt b/scripts/fiber/tests-passing-except-dev.txt
@@ -24,8 +24,6 @@ src/renderers/dom/shared/__tests__/CSSPropertyOperations-test.js
 * should warn about style containing a NaN value
 
 src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
-* should warn for unknown prop
-* should group multiple unknown prop warnings together
 * should warn for onDblClick prop
 * should emit a warning once for a named custom component using shady DOM
 * should not warn when server-side rendering `onScroll`

diff --git a/src/renderers/dom/fiber/ReactDOMFiberComponent.js b/src/renderers/dom/fiber/ReactDOMFiberComponent.js
@@ -343,9 +343,7 @@ function updateDOMProperties(
         domElement,
         propKey
       );
-    } else if (
-        DOMProperty.properties[propKey] ||
-        DOMProperty.isCustomAttribute(propKey)) {
+    } else {
       DOMPropertyOperations.deleteValueForProperty(domElement, propKey);
     }
   }
@@ -420,9 +418,7 @@ function updateDOMProperties(
         propKey,
         nextProp
       );
-    } else if (
-        DOMProperty.properties[propKey] ||
-        DOMProperty.isCustomAttribute(propKey)) {
+    } else {
       // If we're updating to null or undefined, we should remove the property
       // from the DOM node instead of inadvertently setting to a string. This
       // brings us in line with the same behavior we have on initial render.