Production release 20231120 #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build of the nhsx site was being broken by some incompatible changes which had been made to poetry. These changes enforce the use of poetry 1.2.2 which works with the pyproject file as currently configured, and should allow the build to complete allowing the site to be deployed again. to test: download this branch, and uncomment the line 127 in docker/web/Dockerfile then run script/setup to build the site. confirm that the build completes. this should confirm that the build as configured in Dockerfile-prod will work as expected.
Fix the build
This commit makes some minor changes to the branding of the NHSx site changing the logo to the NHS England logo, ensuring that it displays at 60px high, and changing the Site name text from "NHS England - Transformation Directorate" to "Transformation Directorate" To test: - view any page on the local site and confirm that the logo now displays NHS England, rather than just NHS - Confirm that the Site title displayed is now Transformation Directorate. You may need to clear the cache in the admin section to see the changes
Change NHS logo and Site brand text
snim2
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release deploys the change that fixes the build process to production,
along with a couple of minor branding changes:
at 60px high, and changing the Site name text from
To test:
NHS England, rather than just NHS