Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional qualitative (add the option to disable text responses) #42

Merged
merged 6 commits into from
Oct 22, 2020

Conversation

the-nathan-smith
Copy link
Contributor

Allows users to disable text responses from the feedback form.

@prembonsall
Copy link
Contributor

Do we know if we want the default to be text comments enabled or should the default be the yes/no?

@the-nathan-smith
Copy link
Contributor Author

On review of the Acceptance Criteria it does say "The form does not offer qualitative question as default" so will need to rework this.

@the-nathan-smith
Copy link
Contributor Author

Made changes and now the default is that the form will not ask for text responses. The user instead has to enable text responses, details of how to do so are included in the readme.

Copy link
Contributor

@prembonsall prembonsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

README.md Outdated Show resolved Hide resolved
local.settings.json Outdated Show resolved Hide resolved
src/confirmation/index.js Outdated Show resolved Hide resolved
src/confirmation/template.html Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@the-nathan-smith
Copy link
Contributor Author

Thanks for the comments @mikemonteith, will get to work on these changes.

Copy link
Contributor Author

@the-nathan-smith the-nathan-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes requested.

@the-nathan-smith the-nathan-smith merged commit aabd922 into master Oct 22, 2020
@the-nathan-smith the-nathan-smith deleted the optional-qualitative branch July 26, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants