Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SonarCloud code smells #100

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix SonarCloud code smells #100

merged 2 commits into from
Jan 8, 2024

Conversation

the-nathan-smith
Copy link
Contributor

  • Add DOCTYPE to HTML pages
  • Add Lang to HTML tag
  • Move commented code to README

mayank1211
mayank1211 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@mayank1211 mayank1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@the-nathan-smith the-nathan-smith merged commit 1907c26 into master Jan 8, 2024
3 checks passed
@the-nathan-smith the-nathan-smith deleted the fix-code-smells branch January 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayank1211 mayank1211 mayank1211 approved these changes

@sikanderakbarali sikanderakbarali Awaiting requested review from sikanderakbarali

@roshaanbajwa roshaanbajwa Awaiting requested review from roshaanbajwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-nathan-smith @mayank1211