Announce whitespace in screen reader announcements of visually hidden text #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheung-nhs
previously requested changes
Jun 10, 2024
frankieroberto
dismissed
mcheung-nhs’s stale review
Moved position:absolute back down
|
Tested on VoiceOver and I can hear it working when we have a space inside a visually hidden span 👍 Would like to remove the 'Styles' example testing pages before merging though. |
… text This fixes a bug in the nhsuk-u-visually-hidden helper class where any whitespace surrounding visually hidden text isn't announced by screen readers. This fix was added to `govuk-frontend` in [pull request #3868](alphagov/govuk-frontend#3836) and has been re-applied here. Thanks to @hannalaakso for the work upstream. Co-Authored-By: hannalaakso <5007934+hannalaakso@users.noreply.github.com>
frankieroberto
force-pushed
the
include-space-in-visually-hidden-text
branch
from
3df9ef7 to
6b0d156
Compare
|
@anandamaryon1 @edwardhorsford I’ve removed the test pages from the examples so this is now just the CSS changes (and I’ve squashed all the commits into 1). Think this can now be merged?! |
|
Backstop to the rescue… caught something… Visually hidden change has affected the responsive table head styling, showing extra white space elements:
|
anandamaryon1
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the nhsuk-u-visually-hidden helper class where any whitespace surrounding visually hidden text isn't announced by screen readers.
This fix was added to
govuk-frontendin pull request #3868 and released in v4.7.0 and has been re-applied here.Thanks to @hannalaakso for the work upstream. 🙌
I’ve also followed the approach of the GOV.UK Design System team of adding a Typography page with examples of using visually-hidden text, to make testing easier.