Remove 24px from typography scale #1139
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.nhsuk-lede-text
).nhsuk-body-l
)nhsuk-heading-s
andnhsuk-heading-m
in combination with this component viaheadingClasses
, you can soon wind up having cards with very similar but inconsistent heading sizes, as I’ve realised to my horror)If you review the updated backstop images, you can see the overall change is slight.
I’ve removed 24px from the scale entirely, but doing so would mean
nhsuk-font-size-24
in markup would no longer work and mixins calling the 24 size would throw an error. We have a few options for this, including around deprecating and providing 26px as a fallback. Before getting into that, I first wanted to get people’s thoughts on this change.Related:
Checklist