Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reverse button (link) text colour #1080

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Fix reverse button (link) text colour #1080

merged 5 commits into from
Nov 27, 2024

Conversation

davidhunter08
Copy link
Contributor

@davidhunter08 davidhunter08 commented Nov 25, 2024 •
edited
Loading

Description

Fixes nhsuk/nhsuk-service-manual-community-backlog#7 (comment)

Checklist

@davidhunter08 davidhunter08 marked this pull request as ready for review November 25, 2024 14:13
@davidhunter08 davidhunter08 added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) buttons labels Nov 25, 2024
@davidhunter08 davidhunter08 changed the title Fix reverse button text colour Fix reverse button (link) text colour Nov 25, 2024
vickytnz
vickytnz previously approved these changes Nov 25, 2024
View reviewed changes
Copy link

@vickytnz vickytnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me after trying out CSS amend locally.

page with white button and black text

I'm not familiar enough with NHS styling to know if default reverse text colour is supposed to be black rather than NHS blue but this is not my call, I'm just happy that I can now read it!

frankieroberto
frankieroberto previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this fixes the bug (caused by .nhsuk-link:visited overriding .nhuk-link--reverse as it's more specific).

@frankieroberto
Copy link
Contributor

@vickytnz it’s black in the Design System reversed button and on the NHS App design system page. I think it works better than if it was blue on white like the GOV.UK one, which somehow seems less visible when on a blue background?

@frankieroberto
Copy link
Contributor

@davidhunter08 could you add a quick note to the changelog?

@davidhunter08
Copy link
Contributor Author

@davidhunter08 could you add a quick note to the changelog?

done 👍

anandamaryon1
anandamaryon1 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@anandamaryon1 anandamaryon1 merged commit 4a5ce91 into main Nov 27, 2024
5 checks passed
@anandamaryon1 anandamaryon1 deleted the reverse-button-fix branch November 27, 2024 15:54
paulrobertlloyd pushed a commit that referenced this pull request Nov 28, 2024
@davidhunter08 @paulrobertlloyd
Fix reverse button (link) text colour (#1080)
a707c4a 
* add reverse button visited text colour

* remove link example

* refactor css

* revert example

* add changelog entry
paulrobertlloyd pushed a commit that referenced this pull request Nov 28, 2024
@davidhunter08 @paulrobertlloyd
Fix reverse button (link) text colour (#1080)
e2e4733 
* add reverse button visited text colour

* remove link example

* refactor css

* revert example

* add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandamaryon1 anandamaryon1 anandamaryon1 approved these changes

@frankieroberto frankieroberto frankieroberto approved these changes

@vickytnz vickytnz vickytnz left review comments

Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) buttons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons
4 participants
@davidhunter08 @frankieroberto @vickytnz @anandamaryon1