Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header navigation overflow on desktop #1062

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Oct 31, 2024

Description

Fixes issue where navigation list with too many items would not show the ‘Menu’ toggle on desktop, and items would overflow.

Also updates navigation on desktop breakpoint to match that used at smaller breakpoints (the navigation items ranged left):

Screenshot of desktop navigation.

Checklist

@paulrobertlloyd paulrobertlloyd force-pushed the header-overflow-nav-items-deaktop-2 branch from 20d02f3 to 177c3f8 Compare October 31, 2024 14:38
@paulrobertlloyd paulrobertlloyd force-pushed the header-overflow-nav-items-deaktop-2 branch from 177c3f8 to d43f337 Compare October 31, 2024 14:52
Copy link
Collaborator

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@paulrobertlloyd paulrobertlloyd merged commit 4ae40c2 into main Oct 31, 2024
2 checks passed
@paulrobertlloyd paulrobertlloyd deleted the header-overflow-nav-items-deaktop-2 branch October 31, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants