Fix header navigation overflow on desktop #1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the link to `"/"` labelled `"Home"`, which is currently hardcoded, and only shows up within the navigation menu on mobile screen widths. This link may not be appropriate for all services, which might not have a homepage, or might use a different path for it. It is also unclear whether having a homepage link is always needed in the navigation if the NHS logo also goes to the homepage.
paulrobertlloyd
added
🐛 bug
paulrobertlloyd
force-pushed
the
header-overflow-nav-items-desktop
branch
from
b9e160e to
8c40c97
Compare
3 tasks
|
Nice, logic seems to work well. Style wise, at 990 width the links go centred and lose their dividers. 990px 989px I think perhaps the 989px styling should be preserved at larger screens too? Thoughts? @paulrobertlloyd Also looks like we need the page container max-width on the overflow menu items. |
|
I agree, and that styling is fixed in #1059. This PR fixes the broken JS only (and so can be included in the next minor release). |
11 tasks
|
Will create a new PR as this one now includes breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where navigation list with too many items would not show the ‘Menu’ toggle on desktop, and items would overflow.
Checklist