Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove unused Collection.or() #624

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

dilyanpalauzov
Copy link

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

@seonim-ryu
Copy link
Member

Can one of the admins verify this patch?

@jungeun-cho
Copy link
Contributor

ok to test

@jungeun-cho
Copy link
Contributor

[6/12] I confirmed.

@jungeun-cho jungeun-cho self-requested a review June 12, 2020 02:45
@jungeun-cho jungeun-cho merged commit de3ecf8 into nhn:master Jun 12, 2020
@dilyanpalauzov dilyanpalauzov deleted the collection_or branch June 12, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants