Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve broken arrow top position(fix #593) #594

Merged
merged 2 commits into from
Apr 28, 2020
Merged

fix: resolve broken arrow top position(fix #593) #594

merged 2 commits into from
Apr 28, 2020

Conversation

jungeun-cho
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

fix: resolve broken arrow top position(fix #593)

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

seonim-ryu
seonim-ryu approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[4/27] 리뷰 완료합니다!

dongsik-yoo
dongsik-yoo reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[04/28] 리뷰 완료합니다.

@jungeun-cho jungeun-cho merged commit 8a70e1d into master Apr 28, 2020
@jungeun-cho jungeun-cho deleted the fix/issue-593 branch April 28, 2020 02:13
@jungeun-cho jungeun-cho added this to the v1.12.13 milestone Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsik-yoo dongsik-yoo dongsik-yoo left review comments

@seonim-ryu seonim-ryu seonim-ryu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12.13
Development

Successfully merging this pull request may close these issues.

Incorrect placement the arrow in the schedule details popup
3 participants
@jungeun-cho @seonim-ryu @dongsik-yoo