Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable then enable useDetailPopup creates an error #699

Closed
PSVcode opened this issue Sep 19, 2020 · 6 comments · Fixed by #1025
Closed

Disable then enable useDetailPopup creates an error #699

PSVcode opened this issue Sep 19, 2020 · 6 comments · Fixed by #1025
Labels

Comments

@PSVcode
Copy link

PSVcode commented Sep 19, 2020

Version

/*!

Development Environment

OSX Mojave 10.14.6 / Chrome Version 85.0.4183.102 (Build officiel) (64 bits)

Current Behavior

If I disable detail popups, it works. But it crashes when I try to enable them again. Maybe this is not the right way to do it...

// Write example code
cal.setOptions({useDetailPopup:true});
cal.setOptions({useDetailPopup:false});
cal.setOptions({useDetailPopup:true}); // crash

The problem also arises if you type this sample code in the console at https://nhn.github.io/tui.calendar/latest/tutorial-example00-basic. Here is the reported error :

weekView.js:329 Uncaught TypeError: Cannot read property 'off' of undefined
at Week.weekView._beforeDestroy (weekView.js:329)
at Week../src/js/view/view.js.View._destroy (view.js:153)
at Week../src/js/view/view.js.View.destroy (view.js:174)
at Collection. (layout.js:52)
at o (tui-code-snippet.min.js:7)
at Collection../src/js/common/collection.js.Collection.each (collection.js:425)
at Layout../src/js/view/layout.js.Layout.clear (layout.js:51)
at Calendar../src/js/factory/calendar.js.Calendar.changeView (calendar.js:1576)
at Calendar../src/js/factory/calendar.js.Calendar.setOptions (calendar.js:1715)
at :1:5

Expected Behavior

Enable again the datail popups.

@jungeun-cho
Copy link
Contributor

I reproduced. This is a bug and will be fixed.

@WillTA5
Copy link

WillTA5 commented Dec 8, 2021

I'm having this issue too, wondering if there's any news?

@adhrinae
Copy link
Contributor

adhrinae commented Dec 9, 2021

@WillTA5
Sorry, There's no progress about this issue yet.
I'll investigate the cause and try to fix it. Possibly before the end of this year if I can.

@Raketten1963
Copy link

I am having this issue too. Wondering, is there any news?

@adhrinae
Copy link
Contributor

adhrinae commented Feb 3, 2022

@Raketten1963
I forgot this issue while fixing other issues. My bad.
I need to investigate the problem first, then I'll plan the release of the fixed version.

@adhrinae
Copy link
Contributor

@WillTA5 @Raketten1963 @PSVcode

The issue is resolved. Please use the latest version(v1.15.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants