Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

end.getTime is not a function #462

Closed
zhangzhaoyong opened this issue Nov 14, 2019 · 1 comment · Fixed by SimHub/simhub-electron-calendar#3
Closed

end.getTime is not a function #462

zhangzhaoyong opened this issue Nov 14, 2019 · 1 comment · Fixed by SimHub/simhub-electron-calendar#3
Assignees
@dongsik-yoo
Labels
Bug NHN P❕❕❕ Height Priority

Comments

@zhangzhaoyong
Copy link

1.12.7

Google Chrome 78.0.3904.97

Current Behavior

                    period = datetime.range(
                        viewModel.getStarts(),
                        viewModel.getEnds(),
                        datetime.MILLISECONDS_PER_DAY
                    );

image

Expected Behavior

                period = datetime.range(
                    datetime.start(viewModel.getStarts()),
                    datetime.end(viewModel.getEnds()),
                    datetime.MILLISECONDS_PER_DAY
                );
@jungeun-cho
Copy link
Contributor

@zhangzhaoyong
We will analyze the cause.

@dongsik-yoo dongsik-yoo self-assigned this Nov 29, 2019
dongsik-yoo pushed a commit that referenced this issue Nov 29, 2019
fix: Date convert wrong type as number (close #462)
0a6805c
dongsik-yoo pushed a commit that referenced this issue Dec 5, 2019
fix: Date convert wrong type as number (close #462) (#471)
c1d6967 
* fix: Date convert wrong type as number (close #462)

* fix: broken test case

* refactor: apply code review
@snyk-bot snyk-bot mentioned this issue Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongsik-yoo dongsik-yoo

Labels
Bug NHN P❕❕❕ Height Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade tui-calendar from 1.12.6 to 1.12.11 SimHub/simhub-electron-calendar
3 participants
@zhangzhaoyong @dongsik-yoo @jungeun-cho