Skip to content

Allow internal entity classess/interfaces in .NET Standard 2.0 #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2022
Merged

Allow internal entity classess/interfaces in .NET Standard 2.0 #3160

merged 2 commits into from
Sep 14, 2022

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Sep 13, 2022 •
edited
Loading

From #1814

This is supported at least in .NET 4.6+ and .NET Core 2.0. In .NET Standard fallback to the old method.

@hazzik Why fallback? I tested .NET Standard 2.0 lib on both .NET 4.8 and .NET Core 2 and it works.

@hazzik
Copy link
Member

hazzik commented Sep 13, 2022

It was done under an assumption that there could be other runtimes than .NET 4.6 and .NET Core that might not support that.

@hazzik hazzik enabled auto-merge (squash) September 14, 2022 03:03
@hazzik hazzik added this to the 5.4 milestone Sep 14, 2022
@hazzik hazzik merged commit 7de0282 into nhibernate:master Sep 14, 2022
@bahusoid bahusoid mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: ByteCode providers p: Minor r: Fixed t: Improvement
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@bahusoid @hazzik