Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PostgreSQL 8.3 dialect #492

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Adding PostgreSQL 8.3 dialect #492

merged 2 commits into from
Jan 20, 2022

Conversation

DavidMoore
Copy link
Contributor

@DavidMoore DavidMoore commented Feb 22, 2021

This would let people specify the Postgres83Dialect when configuring their ISessionFactory using FluentNHibernate.

The Postgres83Dialect in NHibernate just adds support for the PostgreSQL XML datatype:

	/// <summary>
	/// An SQL dialect for PostgreSQL 8.3 and above.
	/// </summary>
	/// <remarks>
	/// PostgreSQL 8.3 supports xml type
	/// </remarks>
	public class PostgreSQL83Dialect : PostgreSQL82Dialect
	{
		public PostgreSQL83Dialect()
		{
			//https://www.postgresql.org/docs/8.3/static/datatype-xml.html
			RegisterColumnType(DbType.Xml, "xml");
		}
	}

@DavidMoore
Copy link
Contributor Author

@hazzik Did you want me to help look into the integration build problems?

@hazzik hazzik merged commit 6e28416 into nhibernate:master Jan 20, 2022
@DavidMoore
Copy link
Contributor Author

Cheers @hazzik! Personally there's no pressure here to get this released as yet, it's a "nice to have" feature for us. Thanks for your work.

@hazzik hazzik added the feature label Oct 5, 2022
@hazzik hazzik added this to the vNext milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants