Update NHibernate and net framework #386

jrgcubano · 2018-01-09T18:50:10Z

Implements #385
References #383 #365 #381

First of all,

Thank you all the contributors for maintaining this project for so many years. It has been amaizing to be able to use it. 👍

I needed too urgently to use the project with the the lastest NHibernate, so I have updated the project to the lastest version of NHibernate and projects to the new world of .net.

I think I speak for many when saying that the project should not die. I am open to sharing the project administration and help with its updates from now on if necessary. You can give me access to the repo and I can configure the required steps to integrate this PR.

I have tried everything with an "Unofficial" fork version of the whole process (Cake, AppVeyor, Nuget, etc) in my account. jrgcubano fluent-nhibernate github

General updates:

Projects:

Updated to SDK csproj style
TargetFramework: net461.

NHibernate:

Update to lastest version (5.0.3)

Tests and Specs

Nunit 3+: new runners and update all tests.
MachineSpecifications 0.12+: new runners and update all specs.

Build system:

Cake build: Moved to Cake system because ripple is not longer maintained. We can implement any needed task easily in the feature.
Nuget package and publish.
Github Release Manager: It allows us to automate the creation of releases and publication on github.
AppVeyor as CI/CD. We can use teamcity also if necessary. Just need VS2017 image or netcore2.0 and set the powershell step.

** Note: When NHibernate upgrade the project to NetStandard and NetCore, it will be a matter of small changes to update the projects and the build pipeline.

In case the PR be well received and can be taken into account to accept it. We need some steps to follow and enviroment vars to be defined on appveyor by the repo owner and minor badges changes.

AppVeyor steps:

Appveyor.yml: definition already created.
Add the repo to appveyor
Required enviroment vars:
- GITHUB_USERNAME: jagregory or other with repo access
- GITHUB_TOKEN: We need a token with almost full access (read, write, create releases, create release notes, etc).
- NUGET_API_URL: https://www.nuget.org/api/v2/package
- NUGET_API_KEY:
Accept PR on master, increase git version with a tag (maybe v2.1.0)
Define github known labels and attach this ones to issues, so we can group notes on automatic relases (feature, bug, improvement, breaking change, documentation, technical debt).

Pending:

Coverage and publish to coveralls with Cake task.
Generate docs with Cake task.
Update build wiki documentation
Implement NHibernate new features on other PR.

@jagregory @chester89 Please, let me know what you think about all these changes.

Thanks.

andreas-eriksson · 2018-01-10T09:41:45Z

nuspec/FluentNHibernate.nuspec

+    <tags>ORM DAL NHibernate DataBase ADO.Net Mappings Conventions</tags>
+    <copyright>Copyright (c) James Gregory and contributors (Paul Batum, Hudson Akridge, Gleb Chermennov, Jorge Rodríguez Galán).</copyright>
+    <dependencies>
+  		<dependency id="NHibernate" version="5.0.3" />      


Might be better to use this this syntax [5.0.3, 6.0)

I tend to think that it is better to use the idea of resilient builds. We should always know what version we are using. What do you think?

I don't think that would affect builds since the specific version of NHibernate will be specified in the projects packages.config anyway. I think it will only affect the version that is initially installed into a project the first time someone adds FluentNHibernate.

I am not sure if specifying the upper limit on the NHibernate version is a good idea or not as we don't know if version 6.0 will break any functionality with fluent.

andreas-eriksson · 2018-01-10T09:42:35Z

src/CommonAssemblyInfo.cs

+[assembly: AssemblyVersion("1.1.0.0")]
+[assembly: AssemblyFileVersion("1.1.0.0")]
+[assembly: AssemblyInformationalVersion("1.1.0")]
+[assembly: AssemblyCopyright("Copyright 2008-2017 James Gregory and contributors (Paul Batum, Hudson Akridge, Gleb Chermennov, Jorge Rodríguez Galán). All rights reserved.")]


Change to 2008-2018

Nice! I'll wait a bit for someone else to pronounce with code reviews and then I'll fix what's necessary. Thank you

andreas-eriksson · 2018-01-10T10:10:17Z

src/FluentNHibernate.Testing/FluentNHibernate.Testing.csproj

-    </ProjectReference>
+
+  <ItemGroup>    
+    <PackageReference Include="EntityFramework" Version="6.2.0" />


Do we need a reference to EntityFramework?

Not at the beginning. So I think we can safely remove the dependency from tests and example projects. 👍

andreas-eriksson · 2018-01-10T10:14:15Z

src/FluentNHibernate.Testing/Visitors/RelationshipPairingSpec.cs

@@ -15,7 +15,7 @@ public class when_there_is_any_unpaired_collection_property_alphabetically_befor
        CollectionMapping collectionWithoutBackrefAndAlphabeticallyFirst;
        CollectionMapping collectionWithoutBackrefAndAlphabeticallyLast;
        CollectionMapping collectionWithCorrespondingBackref;
-        ManyToOneMapping referenceFromChildSecondTypeToParent;
+        // ManyToOneMapping referenceFromChildSecondTypeToParent;


Sounds good to me

chester89 · 2018-01-18T10:23:34Z

*@jrgcubano* TeamCity configuration needs to be updated accordingly, if we decide to continue using it going forward ‌ 2018-01-12 13:04 GMT+03:00 Andreas Eriksson <notifications@github.com>:

…

***@***.**** commented on this pull request. ------------------------------ In nuspec/FluentNHibernate.nuspec <#386 (comment)> : > + <metadata xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> + <id>FluentNHibernate</id> + <title>FluentNHibernate</title> + <version>0.0.0</version> + <description>Fluent, XML-less, compile safe, automated, convention-based mappings for NHibernate.</description> + <summary>Fluent, XML-less, compile safe, automated, convention-based mappings for NHibernate.</summary> + <authors>James Gregory and contributors (Paul Batum, Hudson Akridge, Gleb Chermennov, Jorge Rodríguez Galán).</authors> + <owners>jagregory, chester89, jagregory</owners> + <licenseUrl>https://github.com/jagregory/fluent-nhibernate/raw/master/LICENSE</licenseUrl> + <projectUrl>https://github.com/jagregory/fluent-nhibernate</projectUrl> + <iconUrl>https://raw.githubusercontent.com/jagregory/fluent-nhibernate/master/docs/logo-nuget.png</iconUrl> + <requireLicenseAcceptance>false</requireLicenseAcceptance> + <tags>ORM DAL NHibernate DataBase ADO.Net Mappings Conventions</tags> + <copyright>Copyright (c) James Gregory and contributors (Paul Batum, Hudson Akridge, Gleb Chermennov, Jorge Rodríguez Galán).</copyright> + <dependencies> + <dependency id="NHibernate" version="5.0.3" /> I don't think that would affect builds since the specific version of NHibernate will be specified in the projects packages.config anyway. I think it will only affect the version that is initially installed into a project the first time someone adds FluentNHibernate. I am not sure if specifying the upper limit on the NHibernate version is a good idea or not as we don't know if version 6.0 will break any functionality with fluent. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#386 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALnfOw4eNEjVVyTbmQ4s6ErCM1tnq-Pks5tJy4XgaJpZM4RYRxK> .

-- Yours faithfully, Gleb

gudmundurm · 2018-01-28T23:02:50Z

I'm on the same boat as you @jrgcubano, it would be ashame to let this project die. I've been using Fluent nhibernate for about 10 years now and i'm really looking forward to seeing this update being released. Please push on :-)

If you need more hands on deck @chester89 i'm ready to help in every way i can.

With support for .net core 2.0 coming in nhibernate 5.1 (if all works about), these will become very interesting times ! Especially if we get fluent flowing with it ....

jrgcubano · 2018-02-06T08:30:56Z

We are having some problems with continuous integration. We are working on it.

jrgcubano · 2018-02-18T13:34:36Z

FluentNHibernate is back

Finally we shipped the new version. We moved the repo to a github organization (FluentNHibernate). We are planing new changes to be in sync with the next version of NHibernate and NetCore.

https://www.nuget.org/packages/FluentNHibernate

Sorry for the delay!

jrgcubano added 2 commits January 9, 2018 16:25

feat(framework): upgrade nhibernate and csproj style

c7d0e8f

chore(cake): move to official with release and appveyor

d3334d9

jrgcubano mentioned this pull request Jan 9, 2018

What about support NHibernate 4.1? #365

Closed

andreas-eriksson reviewed Jan 10, 2018

View reviewed changes

jgbright mentioned this pull request Feb 1, 2018

Update to NHibernate 5 sharparchitecture/Sharp-Architecture#161

Closed

jrgcubano added 3 commits February 5, 2018 20:05

docs(readme): update appveyor badge url

0c13280

fix(project): minor fix for year and unused package

76a81f0

chore(build): pin cake version to 0.25

a0fe6ad

jrgcubano merged commit ea0ee81 into nhibernate:master Feb 5, 2018

jrgcubano mentioned this pull request Feb 5, 2018

Issue 385 #387

Closed

jrgcubano deleted the upgrade-nhibernate branch February 18, 2018 14:01

jrgcubano added the feature label Mar 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update NHibernate and net framework #386

Update NHibernate and net framework #386

jrgcubano commented Jan 9, 2018 •

edited

Loading

andreas-eriksson Jan 10, 2018

jrgcubano Jan 10, 2018 •

edited

Loading

andreas-eriksson Jan 12, 2018

andreas-eriksson Jan 10, 2018

jrgcubano Jan 10, 2018 •

edited

Loading

andreas-eriksson Jan 10, 2018

jrgcubano Jan 10, 2018 •

edited

Loading

andreas-eriksson Jan 10, 2018

jrgcubano Jan 10, 2018

chester89 commented Jan 18, 2018 via email

gudmundurm commented Jan 28, 2018

jrgcubano commented Feb 6, 2018

jrgcubano commented Feb 18, 2018 •

edited

Loading

Update NHibernate and net framework #386

Update NHibernate and net framework #386

Conversation

jrgcubano commented Jan 9, 2018 • edited Loading

General updates:

Projects:

NHibernate:

Tests and Specs

Build system:

AppVeyor steps:

Pending:

andreas-eriksson Jan 10, 2018

Choose a reason for hiding this comment

jrgcubano Jan 10, 2018 • edited Loading

Choose a reason for hiding this comment

andreas-eriksson Jan 12, 2018

Choose a reason for hiding this comment

andreas-eriksson Jan 10, 2018

Choose a reason for hiding this comment

jrgcubano Jan 10, 2018 • edited Loading

Choose a reason for hiding this comment

andreas-eriksson Jan 10, 2018

Choose a reason for hiding this comment

jrgcubano Jan 10, 2018 • edited Loading

Choose a reason for hiding this comment

andreas-eriksson Jan 10, 2018

Choose a reason for hiding this comment

jrgcubano Jan 10, 2018

Choose a reason for hiding this comment

chester89 commented Jan 18, 2018 via email

gudmundurm commented Jan 28, 2018

jrgcubano commented Feb 6, 2018

jrgcubano commented Feb 18, 2018 • edited Loading

jrgcubano commented Jan 9, 2018 •

edited

Loading

jrgcubano Jan 10, 2018 •

edited

Loading

jrgcubano Jan 10, 2018 •

edited

Loading

jrgcubano Jan 10, 2018 •

edited

Loading

jrgcubano commented Feb 18, 2018 •

edited

Loading