-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to encode stack information into an array #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like we should be overriding formatStack
and formatException
- thoughts?
Also don't forget to update the documentation.
Should I update |
I'll get back to this, got a busy few weeks so don't have time at the moment sorry |
40ccb83
to
7dfc5bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience
- I have a few nit-pick comments
- Please do add to the change log, you can just make the version title
UNRELEASED
and I'll update it and thepyproject.toml
when I package it. - Please consider updating the documentation
Co-authored-by: Nicholas Hairs <nicholashairs@gmail.com>
Co-authored-by: Nicholas Hairs <nicholashairs@gmail.com>
Co-authored-by: Nicholas Hairs <nicholashairs@gmail.com>
Co-authored-by: Nicholas Hairs <nicholashairs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, nice work.
I'll work on releasing this soon
close #35
This PR add options to encode stack information into an array.
exc_info_as_array
is True (Defualt: False), formatter encodeexc_info
into an array.stack_info_as_array
is True (Defualt: False), formatter encodestack_info
into an array.Checks
All tests are passed (including new test cases).