Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): stop contributing to stability once app is stable #2306

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Feb 18, 2025

Stop contributing to stability once the application has become stable, which may happen
on the server before the platform is destroyed or in the browser once hydration is complete.

@arturovt arturovt force-pushed the fix/pending-tasks-stable branch from 730f221 to 32f1bfb Compare February 18, 2025 08:55
Copy link

nx-cloud bot commented Feb 18, 2025

View your CI Pipeline Execution ↗ for commit aac7c9e.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 15s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 5s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 09:17:37 UTC

@arturovt arturovt force-pushed the fix/pending-tasks-stable branch from 32f1bfb to 54aba77 Compare February 18, 2025 08:56
Copy link

pkg-pr-new bot commented Feb 18, 2025

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2306

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2306

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2306

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2306

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2306

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2306

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2306

commit: aac7c9e

Copy link

bundlemon bot commented Feb 18, 2025

BundleMon

Files updated (1)
Status Path Size Limits
fesm2022/ngxs-store.mjs
105.43KB (+517B +0.48%) 105KB / +0.5%
Unchanged files (5)
Status Path Size Limits
fesm2022/ngxs-store-internals.mjs
11.82KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
6.8KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.38KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

Total files change +517B +0.38%

Groups updated (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
32.07KB (+139B +0.43%) +1%

Final result: ❌

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Feb 18, 2025

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
3.98KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
2.96KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.63KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.56KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.46KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.15KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.01KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
861B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
396B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
19.96KB +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Feb 18, 2025

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
+66.28KB +1%
Files removed (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
-70.1KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
-68.24KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
-67.3KB +1%

Total files change -139.36KB -67.77%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Stop contributing to stability once the application has become stable, which may happen
on the server before the platform is destroyed or in the browser once hydration is complete.
@arturovt arturovt force-pushed the fix/pending-tasks-stable branch from 54aba77 to aac7c9e Compare February 18, 2025 09:10
Copy link

codeclimate bot commented Feb 18, 2025

Code Climate has analyzed commit aac7c9e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review February 18, 2025 09:45
@arturovt arturovt merged commit e6bcd3b into master Feb 18, 2025
12 of 15 checks passed
@arturovt arturovt deleted the fix/pending-tasks-stable branch February 18, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant