build: add Angular 19 support #2269

arturovt · 2024-11-21T12:17:22Z

nx-cloud · 2024-11-21T12:18:36Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c9f6d69. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

pkg-pr-new · 2024-11-21T12:18:58Z

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2269

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2269

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2269

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2269

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2269

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2269

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2269

commit: c9f6d69

bundlemon · 2024-11-21T12:23:26Z

BundleMon

Files updated (3)

Status	Path	Size	Limits
❌	fesm2022/ngxs-store.mjs	101.86KB (+1.24KB +1.23%)	103KB / +0.5%
✅	fesm2022/ngxs-store-internals-testing.mjs	6.8KB (-32B -0.46%)	7KB / +0.5%
✅	fesm2022/ngxs-store-experimental.mjs	574B (-862B -60.03%)	2KB / +0.5%

Unchanged files (3)

Status	Path	Size	Limits
✅	fesm2022/ngxs-store-internals.mjs	11.29KB	13KB / +0.5%
✅	fesm2022/ngxs-store-operators.mjs	6.22KB	7KB / +0.5%
✅	fesm2022/ngxs-store-plugins.mjs	2.38KB	3KB / +0.5%

Total files change +371B +0.28%

Groups removed (1)

Status	Path	Size	Limits
✅	@ngxs/store(esm2022)[gzip] _{./esm2022/*/.mjs}	-224.12KB	+1%

Groups updated (1)

Status	Path	Size	Limits
✅	@ngxs/store(fesm2022)[gzip] _{./fesm2022/*.mjs}	31.02KB (+57B +0.18%)	+1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2024-11-21T12:23:28Z

BundleMon (NGXS Plugins)

Unchanged files (9)

Status	Path	Size	Limits
✅	Plugins(fesm2022)[gzip] _{storage-plugin/fesm2022/ngxs-storage-plugin.m js}	4.03KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{router-plugin/fesm2022/ngxs-router-plugin.mjs}	3.01KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs}	2.61KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{websocket-plugin/fesm2022/ngxs-websocket-plug in.mjs}	2.57KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{form-plugin/fesm2022/ngxs-form-plugin.mjs}	2.44KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{devtools-plugin/fesm2022/ngxs-devtools-plugin .mjs}	2.14KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{logger-plugin/fesm2022/ngxs-logger-plugin.mjs}	2.01KB	+0.5%
✅	Plugins(fesm2022)[gzip] _{storage-plugin/fesm2022/ngxs-storage-plugin-i nternals.mjs}	861B	+0.5%
✅	Plugins(fesm2022)[gzip] _{router-plugin/fesm2022/ngxs-router-plugin-int ernals.mjs}	396B	+0.5%

Total files change -30B -0.15%

Groups updated (1)

Status	Path	Size	Limits
✅	All Plugins(fesm2022)[gzip] _{./-plugin/fesm2022/.mjs}	20.04KB (-30B -0.15%)	+0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2024-11-21T12:23:30Z

BundleMon (Integration Projects)

Files added (1)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng19/dist-integration/browser/mai n-(hash).js}	+66.37KB	+1%

Files removed (3)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng18/dist-integration/browser/mai n-(hash).js}	-70.1KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng17/dist-integration/main.(hash) .js}	-68.24KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng16/dist-integration/main.(hash) .js}	-67.3KB	+1%

Total files change -139.27KB -67.72%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

.circleci/config.yml

markwhitfeld

Great work, but it seems that in the following file:
packages\store\experimental\src\pending-tasks.ts
We import ExperimentalPendingTasks from @angular/core.
In Angular 19, this is now available as PendingTasks from @angular/core.
(as a side note, our tests didn't pick up this missing Angular API in this PR, so I think we are short on some test coverage of this feature)

This means that we can move the withExperimentalNgxsPendingTasks utility from the @ngxs/store/experimental sub package to withNgxsPendingTasks in the main @ngxs/store package (unless you can think of a more ideal place?).
Related to this change would be a version bump of NGXS v18 to NGXS v19 (especially because of this breaking change)🎉

arturovt · 2024-11-24T17:30:39Z

I agree.

arturovt · 2024-11-24T17:34:25Z

But we should wait until the Nx allows migrating to Angular 19 in order to update the workspace version too.

markwhitfeld · 2024-11-25T06:57:59Z

What is the dependency on NX which would be blocking us?
Can we not release an NGXS v19 independently of the version of NX?
Surely we can do the workspace update separately.

PS. We should still keep the experimental subpackage around.
We can export the withExperimentalNgxsPendingTasks with a deprecation notice. This function would just use the withNgxsPendingTasks function that has moved to the main package.

arturovt · 2024-11-25T11:35:59Z

We can but not with the pending tasks change. The workspace is using Angular 18 which doesn't expose PendingTasks from the core.

markwhitfeld · 2024-11-25T11:48:26Z

Ok, so we are blocked until this NX PR is merged:
nrwl/nx#28847
That NX PR is, in turn blocked by a number of their dependencies, waiting for upgrade.

Is there any way that we can decouple the angular version that our libraries reference from the version of NX?
I'm wondering if there is something we can do with overrides in the package.json, or if we could use the aliasing functionality of tsconfigs to "redirect" the referenced angular version use in our libraries?
What we build with doesn't necessarily determine what our code references. Any ideas?

markwhitfeld · 2024-11-25T12:11:39Z

The experimental subpackage already references things from the ***@***.***/store` library. We would be moving the functionality to the core lib and referencing it there (having the same direction of reference as the existing refs).

…

On Mon, 25 Nov 2024 at 14:05, Artur ***@***.***> wrote: We can export the withExperimentalNgxsPendingTasks with a deprecation notice. This would throw an error that Entry point @ngxs/store has a circular dependency on itself. — Reply to this email directly, view it on GitHub <#2269 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO3U2JKPHI3EQNN5W72HFT2CMHALAVCNFSM6AAAAABSG3RGQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJXHAZTIMJWGE> . You are receiving this because your review was requested.Message ID: ***@***.***>

arturovt · 2024-11-25T12:17:27Z

I have looked at what NgRx did, they upgraded workspace version w/o waiting for the Nx upgrade.

I upgraded the workspace version and had to update unit tests because components are standalone by default now.

markwhitfeld · 2024-11-25T12:33:00Z

Great work! There may be some usefulness to still have some components as `standalone: false` where we are testing things about modules, but I think that most can be converted.

…

On Mon, 25 Nov 2024 at 14:17, Artur ***@***.***> wrote: I have looked at what NgRx did, they upgraded workspace version w/o waiting for the Nx upgrade. I upgraded the workspace version and had to update unit tests because components are standalone by default now. — Reply to this email directly, view it on GitHub <#2269 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO3U2IAAR42EOPBCQ5GTWT2CMIO3AVCNFSM6AAAAABSG3RGQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJXHA3DAOBZG4> . You are receiving this because your review was requested.Message ID: ***@***.***>

arturovt · 2024-11-25T14:15:34Z

@markwhitfeld what do we with ng16/17/18 integrations? They're not compatible anymore because we're using PendingTasks. Do we remove them completely because we want to bump the version to ngxs@19 and make it compatible with angular >= 19.0.0?

tejasv-tagline · 2024-11-28T04:12:22Z

Is anyone taking care of changes for this PR? Many users are waiting for Angular 19 support.

packages/store/experimental/src/pending-tasks.ts

packages/store/src/pending-tasks.ts

packages/store/experimental/tests/preboot-wait-stable.spec.ts

codeclimate · 2024-11-28T23:03:27Z

Code Climate has analyzed commit c9f6d69 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

markwhitfeld

Great work!!!!
Let's get this released!

build: add Angular 19 support

4a3becc

arturovt marked this pull request as ready for review November 21, 2024 12:25

arturovt requested review from markwhitfeld, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners November 21, 2024 12:25

rhutchison approved these changes Nov 21, 2024

View reviewed changes

markwhitfeld reviewed Nov 22, 2024

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

arturovt added 2 commits November 22, 2024 15:33

build: add job to circle

e502b3d

chore: remove redundant module

481ebb6

markwhitfeld requested changes Nov 24, 2024

View reviewed changes

refactor: upgrade workspace and unit tests

70ca42b

arturovt added 2 commits November 25, 2024 16:10

refactor: update store target unit tests

80cc7e1

refactor: fix create-app build (TS version upgrade)

812eb7a

ngxs deleted a comment from codeclimate bot Nov 25, 2024

arturovt added 4 commits November 26, 2024 17:32

refactor: drop ng16 integration

814a79f

refactor: drop ng17 integration

54b74b1

refactor: drop ng18 integration

8e40046

refactor: upgrade peer dep version

60cc59e

markwhitfeld requested changes Nov 28, 2024

View reviewed changes

arturovt added 2 commits November 29, 2024 00:19

refactor: address feedback

25615db

refactor: remove redundant file

c9f6d69

markwhitfeld approved these changes Nov 29, 2024

View reviewed changes

markwhitfeld merged commit a9e7ff3 into master Nov 29, 2024
14 checks passed

markwhitfeld deleted the build/ng19 branch November 29, 2024 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: add Angular 19 support #2269

build: add Angular 19 support #2269

arturovt commented Nov 21, 2024 •

edited

Loading

nx-cloud bot commented Nov 21, 2024 •

edited

Loading

pkg-pr-new bot commented Nov 21, 2024 •

edited

Loading

bundlemon bot commented Nov 21, 2024 •

edited

Loading

bundlemon bot commented Nov 21, 2024 •

edited

Loading

bundlemon bot commented Nov 21, 2024 •

edited

Loading

markwhitfeld left a comment •

edited

Loading

arturovt commented Nov 24, 2024

arturovt commented Nov 24, 2024

markwhitfeld commented Nov 25, 2024

arturovt commented Nov 25, 2024

markwhitfeld commented Nov 25, 2024

markwhitfeld commented Nov 25, 2024 via email

arturovt commented Nov 25, 2024

markwhitfeld commented Nov 25, 2024 via email

arturovt commented Nov 25, 2024

tejasv-tagline commented Nov 28, 2024

codeclimate bot commented Nov 28, 2024

markwhitfeld left a comment

build: add Angular 19 support #2269

build: add Angular 19 support #2269

Conversation

arturovt commented Nov 21, 2024 • edited Loading

nx-cloud bot commented Nov 21, 2024 • edited Loading

☁️ Nx Cloud Report

pkg-pr-new bot commented Nov 21, 2024 • edited Loading

bundlemon bot commented Nov 21, 2024 • edited Loading

BundleMon

bundlemon bot commented Nov 21, 2024 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Nov 21, 2024 • edited Loading

BundleMon (Integration Projects)

markwhitfeld left a comment • edited Loading

Choose a reason for hiding this comment

arturovt commented Nov 24, 2024

arturovt commented Nov 24, 2024

markwhitfeld commented Nov 25, 2024

arturovt commented Nov 25, 2024

markwhitfeld commented Nov 25, 2024

markwhitfeld commented Nov 25, 2024 via email

arturovt commented Nov 25, 2024

markwhitfeld commented Nov 25, 2024 via email

arturovt commented Nov 25, 2024

tejasv-tagline commented Nov 28, 2024

codeclimate bot commented Nov 28, 2024

markwhitfeld left a comment

Choose a reason for hiding this comment

arturovt commented Nov 21, 2024 •

edited

Loading

nx-cloud bot commented Nov 21, 2024 •

edited

Loading

pkg-pr-new bot commented Nov 21, 2024 •

edited

Loading

bundlemon bot commented Nov 21, 2024 •

edited

Loading

bundlemon bot commented Nov 21, 2024 •

edited

Loading

bundlemon bot commented Nov 21, 2024 •

edited

Loading

markwhitfeld left a comment •

edited

Loading