fix(logger-plugin): run filter function in injection context
#2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 95eed69. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/websocket-plugin
@ngxs/store
commit: |
arturovt
force-pushed
the
fix/logger-plugin-inject
branch
from
b64ce88 to
21b1af6
Compare
In this commit, we wrap the `options.filter` function for the logger plugin to run within the injection context, allowing the retrieval of any injectees that may have properties required for filtering. For example, the user may want to skip logging actions until the app's bootstrap is complete. Additionally, the `isIE` check has been removed from the log writer, as Internet Explorer is no longer supported by Angular.
arturovt
force-pushed
the
fix/logger-plugin-inject
branch
from
21b1af6 to
95eed69
Compare
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (1)
Unchanged files (8)
Total files change -59B -0.28% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (2)
Unchanged files (1)
Total files change -171B -0.08% Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit 95eed69 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.1% change). View more on Code Climate. |
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we wrap the
options.filterfunction for the logger plugin to run withinthe injection context, allowing the retrieval of any injectees that may have properties
required for filtering. For example, the user may want to skip logging actions until the
app's bootstrap is complete.
Additionally, the
isIEcheck has been removed from the log writer, as Internet Exploreris no longer supported by Angular.