fix(store): dispatch return observable should be <void>
#2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5f4992e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
18 tasks
arturovt
force-pushed
the
fix/dispatch-void
branch
from
4c62455 to
963d9fb
Compare
BundleMon (Integration Projects)Unchanged files (2)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
This commit updates all `dispatch` signatures to return `Observable<void>`. Initially, the signature was intended to be `void`, but historically, it was returning `Observable<any>`, where `any` represents the state snapshot. This is a breaking change. We've been delaying this fix for years, but now all the necessary changes should finally be made to allow us to progress with the NGXS code itself. It's especially important to clean up old planned todos as well.
arturovt
force-pushed
the
fix/dispatch-void
branch
from
963d9fb to
5f4992e
Compare
|
Code Climate has analyzed commit 5f4992e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5% (0.0% change). View more on Code Climate. |
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates all
dispatchsignatures to returnObservable<void>. Initially, the signature was intended to bevoid, but historically, it was returningObservable<any>, whereanyrepresents the state snapshot.This is a breaking change. We've been delaying this fix for years, but now all the necessary changes should finally be made to allow us to progress with the NGXS code itself. It's especially important to clean up old planned todos as well.