Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(store): ensure Actions stream leave NGXS execution strategy and cause CDs #1936

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

arturovt
Copy link
Member

No description provided.

@bundlemon
Copy link

bundlemon bot commented Nov 10, 2022

BundleMon

Files updated (2)
Status Path Size Limits
fesm2015/ngxs-store.js
113.97KB (-4.03KB -3.41%) 125KB / +0.5%
fesm5/ngxs-store.js
133.18KB (-4.05KB -2.95%) 145KB / +0.5%
Unchanged files (4)
Status Path Size Limits
fesm5/ngxs-store-operators.js
10.07KB 15KB / +0.5%
fesm2015/ngxs-store-operators.js
9.94KB 15KB / +0.5%
fesm5/ngxs-store-internals.js
6.58KB 20KB / +0.5%
fesm2015/ngxs-store-internals.js
5.65KB 20KB / +0.5%

Total files change -8.08KB -2.81%

Groups updated (6)
Status Path Size Limits
@ngxs/store(umd.min)[gzip]
./bundles/*.umd.min.js
13.5KB (-145B -1.04%) +1%
@ngxs/store(fesm2015)[gzip]
./fesm2015/*.js
26.36KB (-880B -3.16%) +1%
@ngxs/store(fesm5)[gzip]
./fesm5/*.js
28.78KB (-967B -3.18%) +1%
@ngxs/store(umd)[gzip]
./bundles/*.umd.js
39.39KB (-1.06KB -2.62%) +1%
@ngxs/store(esm2015)[gzip]
./esm2015/**/*.js
167.79KB (-4.33KB -2.52%) +1%
@ngxs/store(esm5)[gzip]
./esm5/**/*.js
174.39KB (-4.41KB -2.47%) +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Nov 10, 2022

BundleMon (NGXS Plugins)

Unchanged files (28)
Status Path Size Limits
Plugins(umd)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.js
7.47KB +1%
Plugins(umd)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.js
6.96KB +1%
Plugins(umd)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.js
6.87KB +1%
Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
js
6.5KB +1%
Plugins(umd)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.js
6.44KB +1%
Plugins(umd)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.js
6.16KB +1%
Plugins(umd)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
js
5.77KB +1%
Plugins(fesm5)[gzip]
storage-plugin/fesm5/ngxs-storage-plugin.js
4.17KB +1%
Plugins(fesm2015)[gzip]
storage-plugin/fesm2015/ngxs-storage-plugin.j
s
3.87KB +1%
Plugins(fesm5)[gzip]
hmr-plugin/fesm5/ngxs-hmr-plugin.js
3.62KB +1%
Plugins(fesm5)[gzip]
websocket-plugin/fesm5/ngxs-websocket-plugin.
js
3.53KB +1%
Plugins(fesm2015)[gzip]
hmr-plugin/fesm2015/ngxs-hmr-plugin.js
3.25KB +1%
Plugins(fesm5)[gzip]
router-plugin/fesm5/ngxs-router-plugin.js
3.15KB +1%
Plugins(fesm2015)[gzip]
websocket-plugin/fesm2015/ngxs-websocket-plug
in.js
3.15KB +1%
Plugins(umd.min)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js
3.1KB +1%
Plugins(fesm5)[gzip]
form-plugin/fesm5/ngxs-form-plugin.js
3.07KB +1%
Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin.js
2.89KB +1%
Plugins(fesm5)[gzip]
devtools-plugin/fesm5/ngxs-devtools-plugin.js
2.83KB +1%
Plugins(fesm2015)[gzip]
form-plugin/fesm2015/ngxs-form-plugin.js
2.74KB +1%
Plugins(fesm2015)[gzip]
devtools-plugin/fesm2015/ngxs-devtools-plugin
.js
2.65KB +1%
Plugins(fesm5)[gzip]
logger-plugin/fesm5/ngxs-logger-plugin.js
2.48KB +1%
Plugins(umd.min)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
min.js
2.48KB +1%
Plugins(umd.min)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.min.
js
2.43KB +1%
Plugins(fesm2015)[gzip]
logger-plugin/fesm2015/ngxs-logger-plugin.js
2.37KB +1%
Plugins(umd.min)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.min.js
2.36KB +1%
Plugins(umd.min)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.min.js
2.18KB +1%
Plugins(umd.min)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
min.js
1.95KB +1%
Plugins(umd.min)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.min.js
1.86KB +1%

No change in files bundle size

Unchanged groups (6)
Status Path Size Limits
All Plugins(esm5)[gzip]
./-plugin/esm5/**/.js
118.45KB +1%
All Plugins(esm2015)[gzip]
./-plugin/esm2015/**/.js
113.2KB +1%
All Plugins(umd)[gzip]
./-plugin/bundles/.umd.js
46.17KB +1%
All Plugins(fesm5)[gzip]
./-plugin/fesm5/.js
22.85KB +1%
All Plugins(fesm2015)[gzip]
./-plugin/fesm2015/.js
20.92KB +1%
All Plugins(umd.min)[gzip]
./-plugin/bundles/.umd.min.js
16.36KB +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Nov 10, 2022

BundleMon (Integration Projects)

Files updated (4)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng11-ivy/dist-integration/main.(h
ash).js
70.84KB (-119B -0.16%) +1%
Main bundles(Gzip)
hello-world-ng12-ivy/dist-integration/main.(h
ash).js
67.55KB (-137B -0.2%) +1%
Main bundles(Gzip)
hello-world-ng13-ivy/dist-integration/main.(h
ash).js
69.49KB (-151B -0.21%) +1%
Main bundles(Gzip)
hello-world-ng14-ivy/dist-integration/main.(h
ash).js
65.13KB (-179B -0.27%) +1%

Total files change -586B -0.21%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt force-pushed the test/actions-stream-ticks branch from 1381888 to 4a835c0 Compare November 13, 2022 12:29
@codeclimate
Copy link

codeclimate bot commented Nov 13, 2022

Code Climate has analyzed commit 4a835c0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld merged commit 0208977 into master Nov 20, 2022
@markwhitfeld markwhitfeld deleted the test/actions-stream-ticks branch November 20, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants