fix(router-plugin): prevent router overriding valid navigation #1907

arturovt · 2022-08-07T14:42:59Z

We initially added this check when trying to fix router + storage plugins integration.

We had an open issue related to this (#1204), but I've closed it since I verified the issue is not reproducible anymore with the latest NGXS version. The issue was reproducible with the 3.5.0 version (which was used in the reproducible example). I have upgraded NGXS and removed the checkInitialNavigationOnce method, and the behavior was the same as expected (the issue still wasn't reproducible).

codeclimate · 2022-08-07T14:47:11Z

Code Climate has analyzed commit f453a06 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.2% change).

View more on Code Climate.

bundlemon · 2022-08-07T14:52:08Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	fesm2015/ngxs-store.js	114.1KB (-908B -0.77%)	125KB / +0.5%
✅	fesm5/ngxs-store.js	133.05KB (-915B -0.67%)	145KB / +0.5%

Unchanged files (4)

Status	Path	Size	Limits
✅	fesm5/ngxs-store-operators.js	10.07KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	9.94KB	15KB / +0.5%
✅	fesm5/ngxs-store-internals.js	6.58KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	5.65KB	20KB / +0.5%

Total files change -1.78KB -0.63%

Groups updated (6)

Status	Path	Size	Limits
✅	@ngxs/store(umd.min)[gzip] _{./bundles/*.umd.min.js}	13.42KB (-302B -2.15%)	+1%
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	26.32KB (-357B -1.31%)	+1%
✅	@ngxs/store(fesm5)[gzip] _./fesm5/*.js	28.69KB (-357B -1.2%)	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	39.31KB (-362B -0.89%)	+1%
✅	@ngxs/store(esm5)[gzip] _{./esm5/*/.js}	174.15KB (-1.17KB -0.67%)	+1%
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	167.63KB (-1.18KB -0.7%)	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-08-07T14:52:10Z

BundleMon (NGXS Plugins)

Files updated (4)

Status	Path	Size	Limits
✅	Plugins(umd.min)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. min.js}	2.48KB (-240B -8.63%)	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	2.89KB (-1.13KB -28.16%)	+1%
✅	Plugins(fesm5)[gzip] _{router-plugin/fesm5/ngxs-router-plugin.js}	3.15KB (-1.16KB -26.87%)	+1%
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	6.5KB (-1.21KB -15.71%)	+1%

Unchanged files (24)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.24KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.96KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.87KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	6.44KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	6.16KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	5.77KB	+1%
✅	Plugins(fesm5)[gzip] _{storage-plugin/fesm5/ngxs-storage-plugin.js}	3.95KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	3.64KB	+1%
✅	Plugins(fesm5)[gzip] _{hmr-plugin/fesm5/ngxs-hmr-plugin.js}	3.62KB	+1%
✅	Plugins(fesm5)[gzip] _{websocket-plugin/fesm5/ngxs-websocket-plugin. js}	3.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	3.25KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	3.15KB	+1%
✅	Plugins(umd.min)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js}	3.1KB	+1%
✅	Plugins(fesm5)[gzip] _{form-plugin/fesm5/ngxs-form-plugin.js}	3.07KB	+1%
✅	Plugins(fesm5)[gzip] _{devtools-plugin/fesm5/ngxs-devtools-plugin.js}	2.83KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.74KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	2.65KB	+1%
✅	Plugins(fesm5)[gzip] _{logger-plugin/fesm5/ngxs-logger-plugin.js}	2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.min. js}	2.43KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.37KB	+1%
✅	Plugins(umd.min)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.min.js}	2.32KB	+1%
✅	Plugins(umd.min)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js}	2.18KB	+1%
✅	Plugins(umd.min)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. min.js}	1.95KB	+1%
✅	Plugins(umd.min)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js}	1.86KB	+1%

Total files change -3.74KB -3.42%

Groups updated (6)

Status	Path	Size	Limits
✅	All Plugins(umd.min)[gzip] _{./-plugin/bundles/.umd.min.js}	16.32KB (-240B -1.42%)	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	20.69KB (-1.13KB -5.19%)	+1%
✅	All Plugins(fesm5)[gzip] _{./-plugin/fesm5/.js}	22.63KB (-1.16KB -4.87%)	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	45.94KB (-1.21KB -2.57%)	+1%
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	112.62KB (-3.41KB -2.94%)	+1%
✅	All Plugins(esm5)[gzip] _{./-plugin/esm5/**/.js}	117.87KB (-3.48KB -2.87%)	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-08-07T14:52:12Z

BundleMon (Integration Projects)

Files updated (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.33KB (-114B -0.16%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.41KB (-117B -0.17%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65KB (-122B -0.18%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng11-ivy/dist-integration/main.(h ash).js}	70.69KB (-130B -0.18%)	+1%

Total files change -483B -0.17%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

markwhitfeld

Great! I love the smell of deleted code in the morning!
Bundlemon is your biggest fan.

markwhitfeld · 2022-08-08T18:06:46Z

@arturovt Could you update the change log?

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.4/3.7.5) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.4/3.7.5) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.4/3.7.5) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.7.5`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#375-2022-08-08) [Compare Source](ngxs/store@v3.7.4...v3.7.5) - Performance: Tree-shake no type on the action error [#1858](ngxs/store#1858) - Fix: Give back control to `developmentMode` config property [#1878](ngxs/store#1878) - Fix: Do not use `refCount()` since it makes selectable stream cold [#1883](ngxs/store#1883) - Fix: Remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined [#1889](ngxs/store#1889) - Fix: Avoid incorrectly ordered state observable events [#1908](ngxs/store#1908) - Fix: Router Plugin - Prevent router overriding valid navigation [#1907](ngxs/store#1907) - Fix: Storage Plugin - Provide more meaningful error message when the storage quota exceeds [#1863](ngxs/store#1863) - Fix: Storage Plugin - Ensure the deserialization is not skipped for master key [#1887](ngxs/store#1887) - Fix: Storage Plugin - Do not re-hydrate the whole state when the feature state is added [#1887](ngxs/store#1887) - Fix: Devtools Plugin - Enable time-traveling for navigation actions [#1868](ngxs/store#1868) - Fix: Form Plugin - Prevent actions infinite loop with multiple `ngxsForm` directives [#1890](ngxs/store#1890) - Fix: Do not check if the state class is injectable within the decorator since the `ɵprov` will not exist in JIT mode [#1867](ngxs/store#1867) - Revert: revert select decorator changes and add deprecation note [#1871](ngxs/store#1871) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1497 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

arturovt requested review from markwhitfeld, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners August 7, 2022 14:42

fix(router-plugin): remove initial navigation check

f453a06

arturovt force-pushed the fix/remove-initial-navigation-check branch from 79515ad to f453a06 Compare August 7, 2022 14:43

markwhitfeld approved these changes Aug 8, 2022

View reviewed changes

arturovt and others added 2 commits August 8, 2022 21:13

chore: update CHANGELOG.md

8f7fc66

chore: update CHANGELOG.md

e46201f

markwhitfeld changed the title ~~fix(router-plugin): remove initial navigation check~~ fix(router-plugin): rrevent router overriding valid navigation Aug 8, 2022

markwhitfeld changed the title ~~fix(router-plugin): rrevent router overriding valid navigation~~ fix(router-plugin): prevent router overriding valid navigation Aug 8, 2022

markwhitfeld merged commit 79cbc2a into master Aug 8, 2022

markwhitfeld deleted the fix/remove-initial-navigation-check branch August 8, 2022 18:17

arturovt added this to the v3.7.5 milestone Aug 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(router-plugin): prevent router overriding valid navigation #1907

fix(router-plugin): prevent router overriding valid navigation #1907

arturovt commented Aug 7, 2022

codeclimate bot commented Aug 7, 2022

bundlemon bot commented Aug 7, 2022 •

edited

Loading

bundlemon bot commented Aug 7, 2022 •

edited

Loading

bundlemon bot commented Aug 7, 2022 •

edited

Loading

markwhitfeld left a comment

markwhitfeld commented Aug 8, 2022

fix(router-plugin): prevent router overriding valid navigation #1907

fix(router-plugin): prevent router overriding valid navigation #1907

Conversation

arturovt commented Aug 7, 2022

codeclimate bot commented Aug 7, 2022

bundlemon bot commented Aug 7, 2022 • edited Loading

BundleMon

bundlemon bot commented Aug 7, 2022 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Aug 7, 2022 • edited Loading

BundleMon (Integration Projects)

markwhitfeld left a comment

Choose a reason for hiding this comment

markwhitfeld commented Aug 8, 2022

bundlemon bot commented Aug 7, 2022 •

edited

Loading

bundlemon bot commented Aug 7, 2022 •

edited

Loading

bundlemon bot commented Aug 7, 2022 •

edited

Loading