You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[X] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request
The en.json file should only load once. I know you can wait for .use to complete by subscribing to it and calling setDefaultLang file after, but I was wondering if you wanted to take a different approach in the library:
When the library starts to fetch a translation file, do not fetch any more until that is complete.
I can look into putting out a PR for this, but wanted to see your thoughts before I started. Is this something that should be handled by the lib, or should the user be the one to make sure you aren't calling setDefault and use at the same time for the same language?
Please tell us about your environment:
ngx-translate version: 6.0.0
Angular version: 2.4.8
The text was updated successfully, but these errors were encountered:
This stops multiple requests being made for the same lang file. It will now return the same observable when making duplicate requests for the same language.
Fixes#397Fixes#432Fixes#447FixesGreentube/localize-router#26Fixes#462
I'm submitting a ... (check one with "x")
Current behavior
Expected/desired behavior
The en.json file should only load once. I know you can wait for .use to complete by subscribing to it and calling setDefaultLang file after, but I was wondering if you wanted to take a different approach in the library:
I can look into putting out a PR for this, but wanted to see your thoughts before I started. Is this something that should be handled by the lib, or should the user be the one to make sure you aren't calling setDefault and use at the same time for the same language?
Please tell us about your environment:
ngx-translate version: 6.0.0
Angular version: 2.4.8
The text was updated successfully, but these errors were encountered: