test: build signals library and use output for schematics/migrations …

…tests
ngrx · Dec 15, 2024 · 534514f · 534514f
1 parent 51c3247
commit 534514f
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 45 deletions.
diff --git a/modules/signals/jest.config.ts b/modules/signals/jest.config.ts
diff --git a/modules/signals/migrations/18_0_0-rc_3-protected-state/index.spec.ts b/modules/signals/migrations/18_0_0-rc_3-protected-state/index.spec.ts
@@ -7,7 +7,10 @@ import { createWorkspace } from '@ngrx/schematics-core/testing';
 import { tags } from '@angular-devkit/core';
 
 describe('migrate protectedState', () => {
-  const collectionPath = path.join(__dirname, '../migration.json');
+  const collectionPath = path.join(
+    process.cwd(),
+    'dist/modules/signals/migrations/migration.json'
+  );
   const schematicRunner = new SchematicTestRunner('schematics', collectionPath);
 
   let appTree: UnitTestTree;

diff --git a/modules/signals/migrations/18_0_0-rc_3-writablestatesource/index.spec.ts b/modules/signals/migrations/18_0_0-rc_3-writablestatesource/index.spec.ts
@@ -8,7 +8,10 @@ import * as path from 'path';
 import { LogEntry } from '@angular-devkit/core/src/logger';
 
 describe('18_0_0-rc_3-writablestatesource', () => {
-  const collectionPath = path.join(__dirname, '../migration.json');
+  const collectionPath = path.join(
+    process.cwd(),
+    'dist/modules/signals/migrations/migration.json'
+  );
   const schematicRunner = new SchematicTestRunner('schematics', collectionPath);
 
   let appTree: UnitTestTree;

diff --git a/modules/signals/migrations/19_0_0-rc_0-props/index.spec.ts b/modules/signals/migrations/19_0_0-rc_0-props/index.spec.ts
@@ -7,7 +7,10 @@ import { createWorkspace } from '@ngrx/schematics-core/testing';
 import { tags } from '@angular-devkit/core';
 
 describe('migrate to props', () => {
-  const collectionPath = path.join(__dirname, '../migration.json');
+  const collectionPath = path.join(
+    process.cwd(),
+    'dist/modules/signals/migrations/migration.json'
+  );
   const schematicRunner = new SchematicTestRunner('schematics', collectionPath);
 
   let appTree: UnitTestTree;

diff --git a/modules/signals/project.json b/modules/signals/project.json
@@ -47,23 +47,8 @@
       "outputs": ["{options.outputFile}"]
     },
     "test": {
-      "executor": "nx:run-commands",
-      "options": {
-        "commands": ["nx test-source signals", "nx test-schematics signals"]
-      }
-    },
-    "test-source": {
-      "executor": "@analogjs/vitest-angular:test"
-    },
-    "test-schematics": {
-      "executor": "@nx/jest:jest",
-      "options": {
-        "jestConfig": "modules/signals/jest.config.ts",
-        "runInBand": true,
-        "passWithNoTests": false,
-        "testPathPattern": ["schematics", "migrations"]
-      },
-      "outputs": ["{workspaceRoot}/coverage/modules/signals"]
+      "executor": "@analogjs/vitest-angular:test",
+      "dependsOn": ["build"]
     }
   }
 }
diff --git a/modules/signals/schematics/ng-add/index.spec.ts b/modules/signals/schematics/ng-add/index.spec.ts
@@ -9,7 +9,7 @@ import { createWorkspace } from '@ngrx/schematics-core/testing';
 describe('Signals ng-add Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@ngrx/signals',
-    path.join(__dirname, '../collection.json')
+    path.join(process.cwd(), 'dist/modules/signals/schematics/collection.json')
   );
   const defaultOptions: SchemaOptions = {
     skipPackageJson: false,

diff --git a/modules/signals/tsconfig.spec.json b/modules/signals/tsconfig.spec.json
@@ -7,5 +7,5 @@
     "target": "es2016"
   },
   "files": ["test-setup.ts"],
-  "include": ["jest.config.ts", "**/*.spec.ts", "**/*.test.ts", "**/*.d.ts"]
+  "include": ["**/*.spec.ts", "**/*.test.ts", "**/*.d.ts"]
 }
diff --git a/modules/signals/vite.config.mts b/modules/signals/vite.config.mts
@@ -20,7 +20,6 @@ export default defineConfig(({ mode }) => {
       environment: 'jsdom',
       setupFiles: ['test-setup.ts'],
       include: ['**/*.spec.ts'],
-      exclude: ['migrations/**', 'schematics/**'],
       reporters: ['default']
     },
     define: {