Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a js error #524

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix a js error #524

merged 2 commits into from
Jan 9, 2024

Conversation

nanhantianyi
Copy link
Contributor

@nanhantianyi nanhantianyi commented Jan 7, 2024

Call the js function updateSearchList in clients.html, not base.html.
If it’s called in base.html, all other pages except clients.html will raise a function not defined error.

@0xCA
Copy link
Contributor

0xCA commented Jan 8, 2024

There is no search list on other pages though?
It would be better to call updateSearchList in clients.html instead of moving the function.

@nanhantianyi
Copy link
Contributor Author

There is no search list on other pages though? It would be better to call updateSearchList in clients.html instead of moving the function.

@0xCA Thank you for your suggestion.

@ngoduykhanh ngoduykhanh merged commit 73108f7 into ngoduykhanh:master Jan 9, 2024
1 check passed
@nanhantianyi nanhantianyi deleted the fixjs branch January 10, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants